Re: [pgAdmin][RM5348]LDAP Authentication Support

2020-04-27 Thread Akshay Joshi
Thanks, patch applied. On Mon, Apr 27, 2020 at 8:19 PM Abhilasha Narendra < abhilasha.naren...@enterprisedb.com> wrote: > Hi Akshay, > > PFA the updated patch. > > Regards, > Abhilasha > > > > > > > > On 27-Apr-2020, at 7:08 PM, Dave Page wrote: > > My point is that we should be consistent. If w

Re: [pgAdmin][RM5348]LDAP Authentication Support

2020-04-27 Thread Dave Page
My point is that we should be consistent. If we add detailed docs for those config parameters, let's add them for everything (not necessarily today or this release of course). I do agree with Akshay that this may work better as a table. It shouldn't hold up the release though. On Mon, Apr 27, 20

Re: [pgAdmin][RM5348]LDAP Authentication Support

2020-04-27 Thread Abhilasha Narendra
Currently, the config.py file doesn’t have detailed information about the parameters. Do we need to update that file to include the detailed information? Regards, Abhilasha > On 27-Apr-2020, at 6:39 PM, Akshay Joshi > wrote: > > Hi Dave > > On Mon, Apr 27, 2020 at 6:23 PM Dave Page

Re: [pgAdmin][RM5348]LDAP Authentication Support

2020-04-27 Thread Akshay Joshi
Hi Abhilasha Getting below error: Warning, treated as error: /Users/akshayjoshi/Developement/pgAdmin4/docs/en_US/getting_started.rst:31:toctree contains reference to nonexisting document ‘enabling_ldap_authentication’ I think you forgot to add ‘enabling_ldap_authentication’ file in the patch.