Re: [pgAdmin][RM4642] port should not be mandatory when a service is provided

2019-09-13 Thread Murtuza Zabuawala
Hi, On Fri, Sep 13, 2019 at 2:32 PM Akshay Joshi wrote: > Hi Murtuza > > On Fri, Sep 13, 2019 at 1:40 PM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi, >> >> We are making assumption here that all user's service file has port & >> username inside them. >> What if they

Re: [pgAdmin][RM4642] port should not be mandatory when a service is provided

2019-09-13 Thread Akshay Joshi
Hi Murtuza On Fri, Sep 13, 2019 at 1:40 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > We are making assumption here that all user's service file has port & > username inside them. > What if they are not present? > 5432 is the default port and the system user is

Re: [pgAdmin][RM4642] port should not be mandatory when a service is provided

2019-09-13 Thread Murtuza Zabuawala
Hi, We are making assumption here that all user's service file has port & username inside them. What if they are not present? If I remember correctly those validation were left intentional when we added service field just to make sure that we connect to DB server from pgAdmin4 regardless of those

Re: [pgAdmin][RM4642] port should not be mandatory when a service is provided

2019-09-12 Thread Aditya Toshniwal
Looks good to me. On Fri, Sep 13, 2019 at 8:05 AM Akshay Joshi wrote: > Can someone please review this. > > On Mon, 9 Sep, 2019, 18:06 Akshay Joshi, > wrote: > >> Hi Hackers, >> >> Attached is the patch to fix the RM #4642 "port should not be mandatory >> when a service is provided". *Cyril Jou

Re: [pgAdmin][RM4642] port should not be mandatory when a service is provided

2019-09-12 Thread Akshay Joshi
Can someone please review this. On Mon, 9 Sep, 2019, 18:06 Akshay Joshi, wrote: > Hi Hackers, > > Attached is the patch to fix the RM #4642 "port should not be mandatory > when a service is provided". *Cyril Jouve* has sent the initial patch, > but that only removes the validation on GUI, when w