Re: [pgAdmin][RM4279] : Issue with File Browser Home button

2020-05-04 Thread Akshay Joshi
Thanks, patch applied. On Wed, Apr 29, 2020 at 5:26 PM Yogesh Jain wrote: > Hi all, > > Here is an updated patch as per the review comments mentioned above. > > Please review the updated patch. > PFA. > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software Indi

Re: [pgAdmin][RM4279] : Issue with File Browser Home button

2020-04-29 Thread Yogesh Jain
Hi all, Here is an updated patch as per the review comments mentioned above. Please review the updated patch. PFA. RM4279v4.patch Description: Binary data

Re: [pgAdmin][RM4279] : Issue with File Browser Home button

2020-04-27 Thread Akshay Joshi
Hi Yogesh Tested on MAC OSX in both the mode (server, desktop) it is showing "/". Please reverify it. On Mon, Apr 27, 2020 at 10:58 AM Yogesh Jain wrote: > Hi Hackers, > > I have tested this patch in linux (Ubuntu 18.04) env only , which is > working fine. It will be great if someone can review

Re: [pgAdmin][RM4279] : Issue with File Browser Home button

2020-04-26 Thread Yogesh Jain
Hi Hackers, I have tested this patch in linux (Ubuntu 18.04) env only , which is working fine. It will be great if someone can review/test in the Windows environment as well as I don't have the setup ready for that. On Mon, Apr 27, 2020 at 10:47 AM Yogesh Jain wrote: > Hi Aditya, > > Thanks for

Re: [pgAdmin][RM4279] : Issue with File Browser Home button

2020-04-26 Thread Yogesh Jain
Hi Aditya, Thanks for the feedback. Here is an updated patch, regarding the same. Please Review. PFA. On Mon, Apr 27, 2020 at 9:05 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Yogesh, > > Just did an eyeball review. You've included homedir path in the response > rendered

Re: [pgAdmin][RM4279] : Issue with File Browser Home button

2020-04-26 Thread Aditya Toshniwal
Hi Yogesh, Just did an eyeball review. You've included homedir path in the response rendered JS file. You're exposing underlying directory structure to users even in server mode. This is not appropriate. This info should remain at the server and not at the client side. +homedir=os.path.exp