Re: [pgAdmin][RM3904] Replace charting library Flotr2 with ChartJS using React

2020-07-29 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jul 27, 2020 at 5:50 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch to resolve the raised concerns. > > On Fri, Jul 24, 2020 at 5:37 PM Dave Page wrote: > >> Hi >> >> Some further thoughts/comments: >

Re: [pgAdmin][RM3904] Replace charting library Flotr2 with ChartJS using React

2020-07-24 Thread Dave Page
Hi Some further thoughts/comments: - There should be a comment block in every source file, containing the copyright info etc. - Looks like the "new-" in "new-dashboard-graphs" is probably a development artefact and should be removed? - We should probably use .jsx as the extension for React JS fil

Re: [pgAdmin][RM3904] Replace charting library Flotr2 with ChartJS using React

2020-07-23 Thread Dave Page
Very nice. One quick issue that I immediately saw - if the dashboard is not the top-most tab when pgAdmin opens, then when you've selected something on the treeview and then click on the dashboard tab, the graphs don't populate until you select a different object. I'll play some more tomorrow when