Re: [pgAdmin][RM1802] ERD Tool (Beta)

2021-01-25 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jan 25, 2021 at 7:39 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > The attached patch fixes an issue created by existing table name check. > Please review. > > On Mon, Jan 25, 2021 at 5:34 PM Akshay Joshi < > akshay.jo...@enterprisedb.com

Re: [pgAdmin][RM1802] ERD Tool (Beta)

2021-01-25 Thread Aditya Toshniwal
Hi, The attached patch fixes an issue created by existing table name check. Please review. On Mon, Jan 25, 2021 at 5:34 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Mon, Jan 25, 2021 at 5:18 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> Please find t

Re: [pgAdmin][RM1802] ERD Tool (Beta)

2021-01-25 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jan 25, 2021 at 5:18 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Please find the rebased patch from the latest pull. > > On Mon, Jan 25, 2021 at 5:12 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >>

Re: [pgAdmin][RM1802] ERD Tool (Beta)

2021-01-21 Thread Aditya Toshniwal
Hi, On Thu, Jan 21, 2021 at 3:08 PM Dave Page wrote: > > > On Thu, Jan 21, 2021 at 4:48 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Wed, Jan 20, 2021 at 9:20 PM Dave Page wrote: >> >>> Hi >>> >>> Where's the Save Image button gone? I know Aditya was

Re: [pgAdmin][RM1802] ERD Tool (Beta)

2021-01-21 Thread Dave Page
On Thu, Jan 21, 2021 at 4:48 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Wed, Jan 20, 2021 at 9:20 PM Dave Page wrote: > >> Hi >> >> Where's the Save Image button gone? I know Aditya was removing it whilst >> working on other things, but it's still required f

Re: [pgAdmin][RM1802] ERD Tool (Beta)

2021-01-20 Thread Aditya Toshniwal
Hi Dave, On Wed, Jan 20, 2021 at 9:20 PM Dave Page wrote: > Hi > > Where's the Save Image button gone? I know Aditya was removing it whilst > working on other things, but it's still required for phase 1 release. > It was not working 100% right. :( So I've removed it for the time being. I'm still

Re: [pgAdmin][RM1802] ERD Tool (Beta)

2021-01-20 Thread Dave Page
Hi Where's the Save Image button gone? I know Aditya was removing it whilst working on other things, but it's still required for phase 1 release. On Mon, Jan 18, 2021 at 11:45 AM Akshay Joshi wrote: > Thanks, patch applied. > > On Mon, Jan 18, 2021 at 5:08 PM Aditya Toshniwal < > aditya.toshni.

Re: [pgAdmin][RM1802] ERD Tool (Beta)

2021-01-18 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jan 18, 2021 at 5:08 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > OK, So the changes have worked. But still failing at one more place. > Attached the patch fixes it. > > On Mon, Jan 18, 2021 at 4:40 PM Akshay Joshi < > akshay.jo...@enterprisedb.

Re: [pgAdmin][RM1802] ERD Tool (Beta)

2021-01-18 Thread Aditya Toshniwal
OK, So the changes have worked. But still failing at one more place. Attached the patch fixes it. On Mon, Jan 18, 2021 at 4:40 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Mon, Jan 18, 2021 at 2:58 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> The jas

Re: [pgAdmin][RM1802] ERD Tool (Beta)

2021-01-18 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jan 18, 2021 at 2:58 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > The jasmine test cases are working fine on my local machine. The test > cases are successful on jenkins other than on linux, not sure why. > I have made some fixes by look

Re: [pgAdmin][RM1802] ERD Tool (Beta)

2021-01-18 Thread Aditya Toshniwal
Hi, The jasmine test cases are working fine on my local machine. The test cases are successful on jenkins other than on linux, not sure why. I have made some fixes by looking at the log. Please review and try. On Mon, Jan 18, 2021 at 1:10 PM Akshay Joshi wrote: > Thanks, patch applied. > > On M

Re: [pgAdmin][RM1802] ERD Tool (Beta)

2021-01-17 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jan 18, 2021 at 10:34 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Akshay, > > I forgot to remove few of the dependencies which are not required as of > now (may be in future). Attached patch removes those dependencies from > package.json. >

Re: [pgAdmin][RM1802] ERD Tool (Beta)

2021-01-17 Thread Aditya Toshniwal
Hi Akshay, I forgot to remove few of the dependencies which are not required as of now (may be in future). Attached patch removes those dependencies from package.json. On Sat, Jan 16, 2021 at 5:08 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Fri, Jan 15, 2021 at 7:01 PM Aditya Toshniw

Re: [pgAdmin][RM1802] ERD Tool (Beta)

2021-01-16 Thread Akshay Joshi
Thanks, patch applied. On Fri, Jan 15, 2021 at 7:01 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > I've fixed the issues. You can find the comments inline. > I've also added PropTypes for the components for increased validation. > > On Tue, Jan 12, 2021 at 12:18 PM Khus

Re: [pgAdmin][RM1802] ERD Tool (Beta)

2020-12-27 Thread Khushboo Vashi
On Fri, Dec 25, 2020 at 4:34 PM Akshay Joshi wrote: > Hi Khushboo, > > Can you please review it? > > On it. > On Fri, Dec 25, 2020 at 3:31 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached patch introduces ERD Tool(Beta) to pgAdmin. Below are the >

Re: [pgAdmin][RM1802] ERD Tool (Beta)

2020-12-25 Thread Akshay Joshi
Hi Khushboo, Can you please review it? On Fri, Dec 25, 2020 at 3:31 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch introduces ERD Tool(Beta) to pgAdmin. Below are the details: > 1) Create a diagram from scratch or generate for an existing DB. > 2