Re: [pgAdmin][RM-6133]: [React] Port schema diff to React

2022-09-13 Thread Akshay Joshi
Thanks, the patch applied. On Tue, Sep 13, 2022 at 3:59 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > On Tue, Sep 13, 2022 at 3:09 PM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> PFA patch for resolving the following issues reported i

Re: [pgAdmin][RM-6133]: [React] Port schema diff to React

2022-09-13 Thread Nikhil Mohite
Hi Akshay, On Tue, Sep 13, 2022 at 3:09 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > PFA patch for resolving the following issues reported in testing: > >1. When some option from filter is selected, that particular type >should be completely removed from top

Re: [pgAdmin][RM-6133]: [React] Port schema diff to React

2022-09-13 Thread Nikhil Mohite
Hi Akshay, PFA patch for resolving the following issues reported in testing: 1. When some option from filter is selected, that particular type should be completely removed from top level result instead of showing identical:0 2. Copy button is missing for Difference SQL 3. Throw error

Re: [pgAdmin][RM-6133]: [React] Port schema diff to React

2022-09-08 Thread Akshay Joshi
Thanks, the patch applied. On Thu, Sep 8, 2022 at 1:57 PM Nikhil Mohite wrote: > Hi Akshay, > > PFA patch to resolve following issues. > Details: > 1. Resolved resize window issue for DDL result panel. > 2. Updated the Screenshots. > 3. Updated server group title to bold. > > On Wed, Sep 7, 2022

Re: [pgAdmin][RM-6133]: [React] Port schema diff to React

2022-09-07 Thread Akshay Joshi
Thanks, the patch applied. Please send another patch with updated screenshots and the issues you have mentioned. On Wed, Sep 7, 2022 at 6:58 PM Nikhil Mohite wrote: > Hi Akshay, > > PFA updated patch, I have resolved the review comments, there is one issue > with resize window I will send anoth

Re: [pgAdmin][RM-6133]: [React] Port schema diff to React

2022-09-05 Thread Akshay Joshi
Hi Nikhil The review comments are below: - Reduce some space from source selection and target selection. - Inside the select control, make the server group label bold. - There is currently a search icon instead of a filter icon. On the button, change the cursor pointer to none. - A

Re: [pgAdmin][RM-6133]: [React] Port schema diff to React

2022-09-05 Thread Aditya Toshniwal
Hi Nikhil, Few comments: 1. remove commented code // it('SchemaDiff Module', () => { + // // let baseUrl = url_for('schema_diff.initialize'); + // // networkMock.onGet(url_for('debugger.start_listener', {'trans_id': params.transId})).reply(200, {'success':1,'errormsg':'','info':'','result