Re: [RM2522] Improve grid/column select all operation

2017-06-30 Thread Dave Page
On Fri, Jun 30, 2017 at 9:39 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > This patch is not related to improve copy/past operation. It's only > related to grid selection. > The improvement is only between when user clicks on grid select all column > to until all row are s

Re: [RM2522] Improve grid/column select all operation

2017-06-30 Thread Harshal Dhumal
Hi, This patch is not related to improve copy/past operation. It's only related to grid selection. The improvement is only between when user clicks on grid select all column to until all row are selected (turned into blue). With large columns though improvement is not large but it not putting any

Re: [RM2522] Improve grid/column select all operation

2017-06-30 Thread Dave Page
On Fri, Jun 30, 2017 at 8:57 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > I guess so, number of columns do have overhead on selection & copy/paste > operation because of arbitrary copy paste feature, now we have to scan > start cell (first selected cell) & end cell (last se

Re: [RM2522] Improve grid/column select all operation

2017-06-30 Thread Murtuza Zabuawala
++ Corrected sentence On Fri, Jun 30, 2017 at 1:27 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > I guess so, number of columns do have overhead on selection & copy/paste > operation because of arbitrary copy paste feature, now we have to scan > start cell (first selected ce

Re: [RM2522] Improve grid/column select all operation

2017-06-30 Thread Murtuza Zabuawala
I guess so, number of columns do have overhead on selection & copy/paste operation because of arbitrary copy paste feature, now we have to scan start cell (first selected cell) & end cell (last selected cell) for each row, In old code we were selecting complete row which was fast but now user can s

Re: [RM2522] Improve grid/column select all operation

2017-06-29 Thread Dave Page
Hi On Thursday, June 29, 2017, Harshal Dhumal wrote: > > > On Thu, Jun 29, 2017 at 4:33 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com > > wrote: > >> Hi, >> >> Please find attached patch for RM2522. >> >> With this patch grid/column select all time is reduce to ~1 second from >> 8-10 se

Re: [RM2522] Improve grid/column select all operation

2017-06-29 Thread Harshal Dhumal
On Thu, Jun 29, 2017 at 4:33 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch for RM2522. > > With this patch grid/column select all time is reduce to ~1 second from > 8-10 seconds. > This benchmarking is performed with 100k rows and 2 columns (int,