Raise an exception under Python < 3.4 for WSGI mode.
refs #5443
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f1963401d6774631ac4880e891b6cd9a1d4e0e85
Modified Files
--
web/pgAdmin4.wsgi | 4
1 file changed, 4 insertions(+)
Thanks, patch applied.
Also, search PY2 and removed all the references by correcting the logic.
On Thu, Apr 30, 2020 at 1:45 PM Dave Page wrote:
> Hi Akshay,
>
> Sure, go for it.
>
> On Thu, Apr 30, 2020 at 9:14 AM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Dave
>>
>> Can we
Raise an exception under Python < 3.4.
It also cleans up the README to remove references to Python 2
and removes Python 2-isms from the main config.
refs #5443
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
Hi Akshay,
Sure, go for it.
On Thu, Apr 30, 2020 at 9:14 AM Akshay Joshi
wrote:
> Hi Dave
>
> Can we add a similar exception in our test suites? Instead of throwing
> import error, it would be good. If you agree I'll modify the logic.
>
> On Mon, Apr 27, 2020 at 9:27 PM Dave Page wrote:
>
>> T
Hi Dave
Can we add a similar exception in our test suites? Instead of throwing
import error, it would be good. If you agree I'll modify the logic.
On Mon, Apr 27, 2020 at 9:27 PM Dave Page wrote:
> The attached patch raises an exception if run under Python < 3.4. It also
> cleans up the README
Hi,
On Wed, Apr 29, 2020 at 2:52 PM Dave Page wrote:
> Hi
>
> On Wed, Apr 29, 2020 at 10:13 AM Neel Patel
> wrote:
>
>> Hi Dave,
>>
>> Patch looks good to me except one condition as we do support from Python
>> 3.4 onwards. I have modified that condition and attached the updated patch.
>>
>
> W
Hi
On Wed, Apr 29, 2020 at 10:13 AM Neel Patel
wrote:
> Hi Dave,
>
> Patch looks good to me except one condition as we do support from Python
> 3.4 onwards. I have modified that condition and attached the updated patch.
>
What did you change exactly (curious about what I missed)?
>
> I have a
Hi Dave,
Patch looks good to me except one condition as we do support from Python
3.4 onwards. I have modified that condition and attached the updated patch.
I have also removed the other references of Python2. Attached is the patch.
Do review it and let me know for comments.
Thanks,
Neel Patel
The attached patch raises an exception if run under Python < 3.4. It also
cleans up the README to remove references to Python 2 and removes Python
2-isms from the main config.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterp
