Re: RM5525: Cleanup and refactor the macOS build scripts

Hi On Fri, May 15, 2020 at 12:37 PM Akshay Joshi wrote: > Hi Dave > > Following are my review comments: > >- Code alignment is needed for some places in *build-functions.sh. *I >have shellcheck installed in >PyCharm and it is showing too many

Re: RM5525: Cleanup and refactor the macOS build scripts

Hi Dave Following are my review comments: - Code alignment is needed for some places in *build-functions.sh. *I have shellcheck installed in PyCharm and it is showing too many warnings in this file, not sure we should fix those or not - Foll

Re: RM5525: Cleanup and refactor the macOS build scripts

patch -p0 < ~/Downloads/RM5525.patch On Fri, May 15, 2020 at 6:46 AM Akshay Joshi wrote: > Hi Dave > > Unable to apply the patch. Tried from pgadmin source folder as well as > from the pkg folder. > I run git apply . > > On Thu, May 14, 2020 at 7:01 PM Dave Page wrote: > >> Patch attached. Plea

Re: RM5525: Cleanup and refactor the macOS build scripts

Hi Dave Unable to apply the patch. Tried from pgadmin source folder as well as from the pkg folder. I run git apply . On Thu, May 14, 2020 at 7:01 PM Dave Page wrote: > Patch attached. Please review, but do not commit as this change will > require that PGADMIN_PYTHON_DIR is set on the build sys

RM5525: Cleanup and refactor the macOS build scripts

Patch attached. Please review, but do not commit as this change will require that PGADMIN_PYTHON_DIR is set on the build systems. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM5525.patch Descrip