Re: Pgadmin4 System Stats Extension Design

2023-09-15 Thread Sahil Harpal
Hi Khushboo, Could you please suggest labels for the tables in the Memory and CPU tabs. Also, I'm not able to reproduce the alignment issue that you have mentioned, but I have added a fix to by setting width to 100% maybe it would work. Thank you, Sahil

Re: Pgadmin4 System Stats Extension Design

2023-09-12 Thread Sahil Harpal
Hello Aditya, On Fri, 8 Sept 2023 at 09:04, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Sahil, > > Your PR is showing 135 file changes and a lot of commits which shouldn't > have appeared on your PR. > It is very difficult to identify your changes. Can you please check once?

Re: Pgadmin4 System Stats Extension Design

2023-08-27 Thread Sahil Harpal
Hello everyone, I have raised the PR . I would like to request you all to review the changes and provide your valuable feedback. Your insights and suggestions would be invaluable in ensuring the quality and accuracy of the codebase. Thank you, Sa

Re: Pgadmin4 System Stats Extension Design

2023-08-26 Thread Khushboo Vashi
On Sat, 26 Aug 2023, 11:36 Sahil Harpal, wrote: > Hi Khushboo, > > On Mon, 21 Aug 2023 at 10:03, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Sahil, once the issues get resolved, please raise the PR and we will do >> the final review there. >> > Could you please tell me to whic

Re: Pgadmin4 System Stats Extension Design

2023-08-25 Thread Sahil Harpal
Hi Khushboo, On Mon, 21 Aug 2023 at 10:03, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Sahil, once the issues get resolved, please raise the PR and we will do > the final review there. > Could you please tell me to which branch I should raise the PR? Also, should I remove the code

Re: Pgadmin4 System Stats Extension Design

2023-08-25 Thread Sahil Harpal
I have added the idea of array initialization for the 'Process & handle count' chart. Let me know if similar can be used for all the streaming charts to resolve the graph shifting issue. On Fri, 25 Aug 2023 at 13:34, Sahil Harpal wrote: > Hi Aditya, > On Fri, 25 Aug 2023 at 12:32, Aditya Toshn

Re: Pgadmin4 System Stats Extension Design

2023-08-25 Thread Aditya Toshniwal
On Fri, Aug 25, 2023 at 12:15 PM Sahil Harpal wrote: > Hi Aditya, > > On Fri, 25 Aug 2023 at 12:06, Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Sahil, >> >> On Fri, Aug 25, 2023 at 12:02 PM Sahil Harpal >> wrote: >> >>> Hi Aditya, >>> On Fri, 25 Aug 2023 at 11:29, Adit

Re: Pgadmin4 System Stats Extension Design

2023-08-24 Thread Sahil Harpal
Hi Aditya, On Fri, 25 Aug 2023 at 12:06, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Sahil, > > On Fri, Aug 25, 2023 at 12:02 PM Sahil Harpal > wrote: > >> Hi Aditya, >> On Fri, 25 Aug 2023 at 11:29, Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi

Re: Pgadmin4 System Stats Extension Design

2023-08-24 Thread Aditya Toshniwal
Hi Sahil, On Fri, Aug 25, 2023 at 12:02 PM Sahil Harpal wrote: > Hi Aditya, > On Fri, 25 Aug 2023 at 11:29, Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Sahil, >> On Thu, Aug 24, 2023 at 8:07 PM Sahil Harpal >> wrote: >> >>> Hi, >>> Can we include total space stats (le

Re: Pgadmin4 System Stats Extension Design

2023-08-24 Thread Sahil Harpal
Hi Aditya, On Fri, 25 Aug 2023 at 11:29, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Sahil, > On Thu, Aug 24, 2023 at 8:07 PM Sahil Harpal > wrote: > >> Hi, >> Can we include total space stats (left pie chart) in the same bar chart? >> or would it be better if we keep it sep

Re: Pgadmin4 System Stats Extension Design

2023-08-24 Thread Aditya Toshniwal
Hi Sahil, On Fri, Aug 25, 2023 at 11:30 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Sahil, > > On Thu, Aug 24, 2023 at 8:28 PM Sahil Harpal > wrote: > >> On Sat, 19 Aug 2023 at 16:20, Sahil Harpal >> wrote: >> >>> On Thu, 17 Aug 2023 at 17:57, Khushboo Vashi < >>> khush

Re: Pgadmin4 System Stats Extension Design

2023-08-24 Thread Aditya Toshniwal
Hi Sahil, On Thu, Aug 24, 2023 at 8:28 PM Sahil Harpal wrote: > On Sat, 19 Aug 2023 at 16:20, Sahil Harpal > wrote: > >> On Thu, 17 Aug 2023 at 17:57, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>>- Sometimes graphs start from left and then shift to right. This >>>

Re: Pgadmin4 System Stats Extension Design

2023-08-24 Thread Aditya Toshniwal
Hi Sahil, On Thu, Aug 24, 2023 at 8:07 PM Sahil Harpal wrote: > Hi, > Can we include total space stats (left pie chart) in the same bar chart? > or would it be better if we keep it separate? > [image: image.png] > How do you propose to merge both? I would also suggest using a stacked bar chart

Re: Pgadmin4 System Stats Extension Design

2023-08-24 Thread Sahil Harpal
On Sat, 19 Aug 2023 at 16:20, Sahil Harpal wrote: > On Thu, 17 Aug 2023 at 17:57, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >>- Sometimes graphs start from left and then shift to right. This >>issue I have reported in my initial review too. >> >> For StreamingChart s

Re: Pgadmin4 System Stats Extension Design

2023-08-24 Thread Sahil Harpal
Hi, Can we include total space stats (left pie chart) in the same bar chart? or would it be better if we keep it separate? [image: image.png]

Re: Pgadmin4 System Stats Extension Design

2023-08-22 Thread Khushboo Vashi
On Wed, Aug 23, 2023 at 12:44 AM Sahil Harpal wrote: > Also. what should I use for labeling: mount_point or drive_letter? It's > possible that the query might not return either of these values on some > systems. > For instance, in my case, it's returning values for drive_letter but null > for mou

Re: Pgadmin4 System Stats Extension Design

2023-08-22 Thread Khushboo Vashi
On Tue, Aug 22, 2023 at 11:35 PM Sahil Harpal wrote: > On Mon, 21 Aug 2023 at 09:59, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> On Sat, Aug 19, 2023 at 4:21 PM Sahil Harpal >> wrote: >> >>> On Thu, 10 Aug 2023 at 00:37, Sahil Harpal >>> wrote: >>> Pending Work: >>

Re: Pgadmin4 System Stats Extension Design

2023-08-22 Thread Sahil Harpal
Also. what should I use for labeling: mount_point or drive_letter? It's possible that the query might not return either of these values on some systems. For instance, in my case, it's returning values for drive_letter but null for mount_point. However, in the example provided (here

Re: Pgadmin4 System Stats Extension Design

2023-08-22 Thread Sahil Harpal
On Mon, 21 Aug 2023 at 09:59, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > On Sat, Aug 19, 2023 at 4:21 PM Sahil Harpal > wrote: > >> On Thu, 10 Aug 2023 at 00:37, Sahil Harpal >> wrote: >> >>> Pending Work: >>> >>>1. Process information - >>> - Issue: The pg_sys_process_

Re: Pgadmin4 System Stats Extension Design

2023-08-22 Thread Sahil Harpal
On Tue, 22 Aug 2023 at 16:02, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Sahil, > > On Tue, Aug 22, 2023 at 1:19 PM Sahil Harpal > wrote: > >> Hello Khushboo, >> >> Thank you for sharing this with me. As you can see, towards the end, when >> you encountered the tooltip issue, t

Re: Pgadmin4 System Stats Extension Design

2023-08-22 Thread Khushboo Vashi
Hi Sahil, On Tue, Aug 22, 2023 at 1:19 PM Sahil Harpal wrote: > Hello Khushboo, > > Thank you for sharing this with me. As you can see, towards the end, when > you encountered the tooltip issue, the size of the graph container was > changing. I even found this bug in the actual pgAdmin4 applicat

Re: Pgadmin4 System Stats Extension Design

2023-08-20 Thread Sahil Harpal
pgAdmin4-cursor-rec.mp4 Hi Khushboo, On Mon, 21 Aug 2023 at 09:55, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > On Fri, Aug 18, 2023 at 10:08 AM Sahil Harpal > wrote: > >> On Thu, 17 Aug 2023 a

Re: Pgadmin4 System Stats Extension Design

2023-08-20 Thread Khushboo Vashi
Sahil, once the issues get resolved, please raise the PR and we will do the final review there. On Mon, Aug 21, 2023 at 9:59 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Sat, Aug 19, 2023 at 4:21 PM Sahil Harpal > wrote: > >> On Thu, 10 Aug 2023 at 00:37, Sahil Harpal >>

Re: Pgadmin4 System Stats Extension Design

2023-08-20 Thread Khushboo Vashi
On Sat, Aug 19, 2023 at 4:21 PM Sahil Harpal wrote: > On Thu, 10 Aug 2023 at 00:37, Sahil Harpal > wrote: > >> Pending Work: >> >>1. Process information - >> - Issue: The pg_sys_process_info() query takes much longer (more >> than 2 mins) to execute and prevents the updation of o

Re: Pgadmin4 System Stats Extension Design

2023-08-20 Thread Khushboo Vashi
On Fri, Aug 18, 2023 at 10:08 AM Sahil Harpal wrote: > On Thu, 17 Aug 2023 at 17:57, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >>- The Tooltip for graph points remains on the page. Please refer to >>the below screenshot. >> >> > Is this happening simply by moving the

Re: Pgadmin4 System Stats Extension Design

2023-08-19 Thread Sahil Harpal
On Thu, 10 Aug 2023 at 00:37, Sahil Harpal wrote: > Pending Work: > >1. Process information - > - Issue: The pg_sys_process_info() query takes much longer (more > than 2 mins) to execute and prevents the updation of other graphs and > tables. >2. Disk information - >

Re: Pgadmin4 System Stats Extension Design

2023-08-19 Thread Sahil Harpal
On Thu, 17 Aug 2023 at 17:57, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > >- Sometimes graphs start from left and then shift to right. This issue >I have reported in my initial review too. > > For StreamingChart should I ignore it for now? On Mon, 7 Aug 2023 at 17:12, Aditya

Re: Pgadmin4 System Stats Extension Design

2023-08-17 Thread Sahil Harpal
On Thu, 17 Aug 2023 at 17:57, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > >- The Tooltip for graph points remains on the page. Please refer to >the below screenshot. > > Is this happening simply by moving the cursor within the graph area or when resizing the screen? For me,

Re: Pgadmin4 System Stats Extension Design

2023-08-17 Thread Sahil Harpal
Hi Khushboo, I have made the necessary changes and pushed them to the same repository. Let me know if that resolves this null value issue. Thank you, Sahil >

Re: Pgadmin4 System Stats Extension Design

2023-08-17 Thread Sahil Harpal
On Thu, 17 Aug 2023 at 15:08, Dave Page wrote: > On Thu, 17 Aug 2023 at 10:36, Sahil Harpal > wrote: > >> On Thu, 17 Aug 2023 at 14:53, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> On Thu, Aug 17, 2023 at 2:50 PM Sahil Harpal >>> wrote: >>> [image: image.gif] On

Re: Pgadmin4 System Stats Extension Design

2023-08-17 Thread Dave Page
On Thu, 17 Aug 2023 at 10:36, Sahil Harpal wrote: > On Thu, 17 Aug 2023 at 14:53, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> On Thu, Aug 17, 2023 at 2:50 PM Sahil Harpal >> wrote: >> >>> On Thu, 17 Aug 2023 at 14:39, Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrot

Re: Pgadmin4 System Stats Extension Design

2023-08-17 Thread Sahil Harpal
On Thu, 17 Aug 2023 at 14:53, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > On Thu, Aug 17, 2023 at 2:50 PM Sahil Harpal > wrote: > >> On Thu, 17 Aug 2023 at 14:39, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Sample data of my system to fix this issue: >>> >>>

Re: Pgadmin4 System Stats Extension Design

2023-08-17 Thread Khushboo Vashi
On Thu, Aug 17, 2023 at 2:50 PM Sahil Harpal wrote: > On Thu, 17 Aug 2023 at 14:39, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Sample data of my system to fix this issue: >> >>1. process331: >> 1. memory_bytes:null >> 2. memory_usage:null >> 3. name:"Qui

Re: Pgadmin4 System Stats Extension Design

2023-08-17 Thread Sahil Harpal
On Thu, 17 Aug 2023 at 14:39, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Sample data of my system to fix this issue: > >1. process331: > 1. memory_bytes:null > 2. memory_usage:null > 3. name:"QuickLookUIServi" > 4. pid:938 > 5. row_number:331 > > O

Re: Pgadmin4 System Stats Extension Design

2023-08-17 Thread Khushboo Vashi
On Thu, Aug 17, 2023 at 11:48 AM Sahil Harpal wrote: > Hi Khushboo, > > On Thu, 17 Aug 2023 at 10:39, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Can you please fix the below JS error ? Due to this CPU and Memory tabs >> are not working. >> [image: Screenshot 2023-08-17 at 10.

Re: Pgadmin4 System Stats Extension Design

2023-08-16 Thread Sahil Harpal
Hi Khushboo, On Thu, 17 Aug 2023 at 10:39, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Can you please fix the below JS error ? Due to this CPU and Memory tabs > are not working. > [image: Screenshot 2023-08-17 at 10.35.34 AM.png] > For me, it's working properly. I think in your ca

Re: Pgadmin4 System Stats Extension Design

2023-08-16 Thread Khushboo Vashi
Hi Sahil, On Wed, Aug 16, 2023 at 3:25 PM Sahil Harpal wrote: > I have pushed the recent changes to my GitHub repository. > If you are still unable to apply the patch, you can pull it from here. In > the meantime, I'll check what might be wrong with this patch file. > link - https://github.com/S

Re: Pgadmin4 System Stats Extension Design

2023-08-16 Thread Sahil Harpal
I have pushed the recent changes to my GitHub repository. If you are still unable to apply the patch, you can pull it from here. In the meantime, I'll check what might be wrong with this patch file. link - https://github.com/Sahil1479/pgadmin4/tree/system_stats On Wed, 16 Aug 2023 at 11:51, Sahil

Re: Pgadmin4 System Stats Extension Design

2023-08-15 Thread Sahil Harpal
I've noticed something here. I cleared all the errors using 'yarn run bundle:dev,' except for the unused 'counterData' variable, which I'll correct soon. But when I attempted to apply this patch on a freshly cloned repository, it displayed the following warnings. However, it didn't fail, and all th

Re: Pgadmin4 System Stats Extension Design

2023-08-15 Thread Sahil Harpal
Could you please try this attached patch. SS_WIP.patch Description: Binary data

Re: Pgadmin4 System Stats Extension Design

2023-08-15 Thread Khushboo Vashi
Can you please rebase the patch and send it again? On Thu, Aug 10, 2023 at 12:37 AM Sahil Harpal wrote: > Hi all, > > I have attached the updated patch with recent changes. > > New changes: > >1. Displayed the appropriate message If the System Stat extension does >not exist. >2. Prov

Re: Pgadmin4 System Stats Extension Design

2023-08-15 Thread Sahil Harpal
Hi, This email is regarding the recent patch I shared with you. Have you encountered any issues or identified areas for improvement? Additionally, could you assist me in resolving the challenges I'm currently facing and provide suggestions for chart titles? Thanks, Sahil On Thu, 10 Aug 2023 at 00

Re: Pgadmin4 System Stats Extension Design

2023-08-09 Thread Sahil Harpal
Hi all, I have attached the updated patch with recent changes. New changes: 1. Displayed the appropriate message If the System Stat extension does not exist. 2. Provided option to configure refresh rates for the API calls (Preferences settings > Dashboards > Refresh rates). 3. Add

Re: Pgadmin4 System Stats Extension Design

2023-08-07 Thread Aditya Toshniwal
On Mon, Aug 7, 2023 at 4:47 PM Sahil Harpal wrote: > Hi Aditya, > On Mon, 7 Aug 2023 at 11:01, Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Sahil, >> I would suggest changing the behaviour in StreamingChart so that it can >> be used at other places. If you want to revers

Re: Pgadmin4 System Stats Extension Design

2023-08-07 Thread Sahil Harpal
Hi Aditya, On Mon, 7 Aug 2023 at 11:01, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Sahil, > I would suggest changing the behaviour in StreamingChart so that it can be > used at other places. If you want to reverse it then you can still do it. I > had achieved reverse directi

Re: Pgadmin4 System Stats Extension Design

2023-08-06 Thread Aditya Toshniwal
Hi Sahil, On Sun, Aug 6, 2023 at 1:21 PM Sahil Harpal wrote: > Hi Aditya, > On Thu, 3 Aug 2023 at 09:32, Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote > >> Because it is the default behaviour of streaming. You can add a prop >> reverse=true to StreamingChart and change the code r

Re: Pgadmin4 System Stats Extension Design

2023-08-06 Thread Sahil Harpal
Hi Aditya, On Thu, 3 Aug 2023 at 09:32, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote > Because it is the default behaviour of streaming. You can add a prop > reverse=true to StreamingChart and change the code ret.reverse(); based > on condition. > So basically, you are suggesting to

Re: Pgadmin4 System Stats Extension Design

2023-08-02 Thread Aditya Toshniwal
Hi Sahil, On Wed, Aug 2, 2023 at 6:14 PM Sahil Harpal wrote: > Hi Khushboo, > > On Thu, 27 Jul 2023 at 16:26, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> You have made different files tab-wise; it would be more manageable if >> you could put them under a subfolder OR start a

Re: Pgadmin4 System Stats Extension Design

2023-08-02 Thread Sahil Harpal
Hi Khushboo, On Thu, 27 Jul 2023 at 16:26, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > You have made different files tab-wise; it would be more manageable if you > could put them under a subfolder OR start a name with system_state or > something like that. > On Thu, Jul 27, 2023 at

Re: Pgadmin4 System Stats Extension Design

2023-07-27 Thread Khushboo Vashi
On Thu, Jul 27, 2023 at 1:59 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Sahil, > > On Thu, Jul 27, 2023 at 1:09 PM Sahil Harpal > wrote: > >> On Wed, 12 Jul 2023 at 15:58, Sahil Harpal >> wrote: >> >>> On Wed, 12 Jul 2023 at 10:47, Khushboo Vashi < >>> khushboo.va...@enterp

Re: Pgadmin4 System Stats Extension Design

2023-07-27 Thread Khushboo Vashi
Hi Sahil, On Thu, Jul 27, 2023 at 1:09 PM Sahil Harpal wrote: > On Wed, 12 Jul 2023 at 15:58, Sahil Harpal > wrote: > >> On Wed, 12 Jul 2023 at 10:47, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> [image: image.gif] >> >>> It fails while applying. Can you please rebase your pa

Re: Pgadmin4 System Stats Extension Design

2023-07-27 Thread Sahil Harpal
On Wed, 12 Jul 2023 at 15:58, Sahil Harpal wrote: > On Wed, 12 Jul 2023 at 10:47, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > [image: image.gif] > >> It fails while applying. Can you please rebase your patch and send it? >> > > Could you please try the attached patch. > Just a f

Re: Pgadmin4 System Stats Extension Design

2023-07-25 Thread Sahil Harpal
On Mon, 24 Jul 2023 at 16:39, Dave Page wrote: > OK, so F and G are not being shown in the query results (or more > correctly, they are there, but the drive letter is showing as NULL?). If > so, that seems like a bug in the extension. > Yeah, it's showing NULL for the F and G drives. Can anyone p

Re: Pgadmin4 System Stats Extension Design

2023-07-24 Thread Dave Page
On Mon, 24 Jul 2023 at 11:47, Sahil Harpal wrote: > On Mon, 24 Jul 2023 at 15:34, Dave Page wrote: > >> On your system, what are the volumes without letters etc? If they're >> things like swap/pagefile, recovery partition etc, then they can probably >> be omitted (e.g. SELECT ... WHERE mount_poi

Re: Pgadmin4 System Stats Extension Design

2023-07-24 Thread Sahil Harpal
On Mon, 24 Jul 2023 at 15:34, Dave Page wrote: > On your system, what are the volumes without letters etc? If they're > things like swap/pagefile, recovery partition etc, then they can probably > be omitted (e.g. SELECT ... WHERE mount_point IS NOT NULL OR drive_letter > IS NOT NULL). > On my s

Re: Pgadmin4 System Stats Extension Design

2023-07-24 Thread Dave Page
On Mon, 24 Jul 2023 at 10:30, Sahil Harpal wrote: > On Mon, 24 Jul 2023 at 10:57, Ashesh Vashi > wrote: > >> Please share the exact output of the query to get any suggestions. >> > The following is the output returned by the query: > > mount_point | file_system | drive_letter | drive_type | fil

Re: Pgadmin4 System Stats Extension Design

2023-07-24 Thread Sahil Harpal
On Mon, 24 Jul 2023 at 10:57, Ashesh Vashi wrote: > Please share the exact output of the query to get any suggestions. > The following is the output returned by the query: mount_point | file_system | drive_letter | drive_type | file_system_type | > total_space | used_space | free_space | t

Re: Pgadmin4 System Stats Extension Design

2023-07-23 Thread Ashesh Vashi
On Mon, Jul 24, 2023 at 1:30 AM Sahil Harpal wrote: > Hello all, > Regarding the storage tab and the disk information charts, we have decided > to display two charts: > >1. A pie chart to represent the proportion of total space. >2. A bar chart to display the space available and used. > >

Re: Pgadmin4 System Stats Extension Design

2023-07-20 Thread Sahil Harpal
On Wed, Jul 12, 2023, 3:58 PM Sahil Harpal wrote: > > Could you please try the attached patch. > Could you please confirm whether it's working or not? Also is there anything that we can improve in this patch. Thanks, Sahil >

Re: Pgadmin4 System Stats Extension Design

2023-07-20 Thread Sahil Harpal
On Wed, Jul 12, 2023, 4:33 PM Ashesh Vashi wrote: > If it is an extension issue, you may want to create an issue in its github > repo with reproduction steps, current & expected behaviour. > I think the issue is mostly with windows systems can anyone please confirm whether the pg_sys_process_inf

Re: Pgadmin4 System Stats Extension Design

2023-07-12 Thread Ashesh Vashi
On Wed, Jul 12, 2023 at 4:20 PM Sahil Harpal wrote: > On Wed, 12 Jul 2023 at 10:26, Ashesh Vashi > wrote: > >> On Tue, Jul 11, 2023 at 8:45 PM Sahil Harpal >> wrote: >> >>> On Tue, Jul 11, 2023 at 2:29 PM Sahil Harpal >>> wrote: >>> On Tue, 11 Jul 2023 at 12:04, Ashesh Vashi < ashesh

Re: Pgadmin4 System Stats Extension Design

2023-07-12 Thread Sahil Harpal
On Wed, 12 Jul 2023 at 10:26, Ashesh Vashi wrote: > On Tue, Jul 11, 2023 at 8:45 PM Sahil Harpal > wrote: > >> On Tue, Jul 11, 2023 at 2:29 PM Sahil Harpal >> wrote: >> >>> On Tue, 11 Jul 2023 at 12:04, Ashesh Vashi < >>> ashesh.va...@enterprisedb.com> wrote: >>> Try preloading the extensi

Re: Pgadmin4 System Stats Extension Design

2023-07-12 Thread Sahil Harpal
On Wed, 12 Jul 2023 at 10:47, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > It fails while applying. Can you please rebase your patch and send it? > Could you please try the attached patch. WIP.patch Description: Binary data

Re: Pgadmin4 System Stats Extension Design

2023-07-11 Thread Khushboo Vashi
On Tue, Jul 11, 2023 at 8:45 PM Sahil Harpal wrote: > On Tue, Jul 11, 2023 at 2:29 PM Sahil Harpal > wrote: > >> On Tue, 11 Jul 2023 at 12:04, Ashesh Vashi >> wrote: >> >>> Try preloading the extension in the PostgreSQL server. >>> e.g. Add this extension in the 'shared_preload_libraries' in >

Re: Pgadmin4 System Stats Extension Design

2023-07-11 Thread Ashesh Vashi
On Tue, Jul 11, 2023 at 8:45 PM Sahil Harpal wrote: > On Tue, Jul 11, 2023 at 2:29 PM Sahil Harpal > wrote: > >> On Tue, 11 Jul 2023 at 12:04, Ashesh Vashi >> wrote: >> >>> Try preloading the extension in the PostgreSQL server. >>> e.g. Add this extension in the 'shared_preload_libraries' in >

Re: Pgadmin4 System Stats Extension Design

2023-07-11 Thread Sahil Harpal
On Tue, Jul 11, 2023 at 2:29 PM Sahil Harpal wrote: > On Tue, 11 Jul 2023 at 12:04, Ashesh Vashi > wrote: > >> Try preloading the extension in the PostgreSQL server. >> e.g. Add this extension in the 'shared_preload_libraries' in >> postgresql.conf. >> >> Reference: https://pgpedia.info/s/share

Re: Pgadmin4 System Stats Extension Design

2023-07-11 Thread Aditya Toshniwal
Hi Sahil, On Tue, Jul 11, 2023 at 2:29 PM Sahil Harpal wrote: > On Tue, 11 Jul 2023 at 12:04, Ashesh Vashi > wrote: > >> Try preloading the extension in the PostgreSQL server. >> e.g. Add this extension in the 'shared_preload_libraries' in >> postgresql.conf. >> >> Reference: https://pgpedia.i

Re: Pgadmin4 System Stats Extension Design

2023-07-11 Thread Sahil Harpal
On Tue, 11 Jul 2023 at 12:04, Ashesh Vashi wrote: > Try preloading the extension in the PostgreSQL server. > e.g. Add this extension in the 'shared_preload_libraries' in > postgresql.conf. > > Reference: https://pgpedia.info/s/shared_preload_libraries.html > Thank you, Ashesh! I will try this an

Re: Pgadmin4 System Stats Extension Design

2023-07-10 Thread Ashesh Vashi
On Tue, Jul 11, 2023 at 11:58 AM Sahil Harpal wrote: > Hi, > > I have written code for the Summary and CPU tabs and would like to post it > here for review. > > I'm currently displaying the static values in the process info pie chart > because of a minor bug. The pg_sys_process_info() query takes

Re: Pgadmin4 System Stats Extension Design

2023-06-26 Thread Sahil Harpal
On Sun, Jun 25, 2023, 3:02 AM Dave Page wrote: > Can you add a different scale on the right hand side? I haven’t > familiarised myself with the library we’re using now, but others I’ve used > can do that. > Yeah sure. I think we can do this by passing few additional configuration options. I'll l

Re: Pgadmin4 System Stats Extension Design

2023-06-24 Thread Dave Page
Can you add a different scale on the right hand side? I haven’t familiarised myself with the library we’re using now, but others I’ve used can do that. On Sat, 24 Jun 2023 at 22:02, Sahil Harpal wrote: > I tried combining the process and handle count in a single graph. But as > you can see in th

Re: Pgadmin4 System Stats Extension Design

2023-06-24 Thread Sahil Harpal
I tried combining the process and handle count in a single graph. But as you can see in the attached image, insights are not properly visible since the difference between the values is too large. Even when the process count is 320, without tooltips, it appears as zero. Can we draw separate graphs f

Re: Pgadmin4 System Stats Extension Design

2023-06-20 Thread Dave Page
On Mon, 19 Jun 2023 at 21:01, Sahil Harpal wrote: > Hi Dave, > > On Mon, 19 Jun 2023 at 20:51, Dave Page wrote: > >> I'd aim for 3 graphs per row on a normal display (Total Reads/Total >> Writes, Bytes Read/Bytes Written, Time Reading/Time Writing). >> > > I am attaching the new design. > I have

Re: Pgadmin4 System Stats Extension Design

2023-06-19 Thread Dave Page
On Mon, 19 Jun 2023 at 16:11, Sahil Harpal wrote: > On Mon, 19 Jun 2023 at 14:07, Dave Page wrote: > >> >> Seems reasonable to me. A wireframe would seem like the best next step, >> to confirm we're all happy with what's proposed. It's hard to visualise >> from a list of bullet points. >> > > Hi

Re: Pgadmin4 System Stats Extension Design

2023-06-19 Thread Dave Page
On Mon, 19 Jun 2023 at 15:30, Sahil Harpal wrote: > On Fri, 16 Jun 2023 at 14:15, Sahil Harpal > wrote: > >> [image: image.gif] >> >>> I think combining R/W is fine, as long as it uses two scales in case the >>> values are wildly different (which is likely). >> >> >> So should I combine all the

Re: Pgadmin4 System Stats Extension Design

2023-06-19 Thread Sahil Harpal
On Fri, 16 Jun 2023 at 14:15, Sahil Harpal wrote: > [image: image.gif] > >> I think combining R/W is fine, as long as it uses two scales in case the >> values are wildly different (which is likely). > > > So should I combine all the parameters (Total read/write operations, Total > Bytes read/writ

Re: Pgadmin4 System Stats Extension Design

2023-06-19 Thread Ashesh Vashi
On Mon, Jun 19, 2023 at 2:07 PM Dave Page wrote: > > > On Sat, 17 Jun 2023 at 10:01, Sahil Harpal > wrote: > >> Hi Dave, >> >> Could you please confirm whether we can proceed with the following >> grouping? >> >> *1. Summary* >> >>- OS information >>- Sys CPU Information >>- Sys Proc

Re: Pgadmin4 System Stats Extension Design

2023-06-19 Thread Dave Page
On Sat, 17 Jun 2023 at 10:01, Sahil Harpal wrote: > Hi Dave, > > Could you please confirm whether we can proceed with the following > grouping? > > *1. Summary* > >- OS information >- Sys CPU Information >- Sys Process Information > > *2. CPU* > >- Sys CPU Usage Information >-

Re: Pgadmin4 System Stats Extension Design

2023-06-17 Thread Sahil Harpal
Hi Dave, Could you please confirm whether we can proceed with the following grouping? *1. Summary* - OS information - Sys CPU Information - Sys Process Information *2. CPU* - Sys CPU Usage Information - Sys Load Avg Information - Process Name/Pid - CPU Usage (From Process) *

Re: Pgadmin4 System Stats Extension Design

2023-06-16 Thread Sahil Harpal
> > I think combining R/W is fine, as long as it uses two scales in case the > values are wildly different (which is likely). So should I combine all the parameters (Total read/write operations, Total Bytes read/write, and time spent) in a single graph for one disk or just the total number of rea

Re: Pgadmin4 System Stats Extension Design

2023-06-15 Thread Dave Page
On Thu, 15 Jun 2023 at 11:07, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Regarding I/O analysis, what would be more beneficial, combining total > read/total write etc., per disk OR Sahil doing a different graph for each > parameter for all the disks? > I think combining R/W is fin

Re: Pgadmin4 System Stats Extension Design

2023-06-15 Thread Khushboo Vashi
Regarding I/O analysis, what would be more beneficial, combining total read/total write etc., per disk OR Sahil doing a different graph for each parameter for all the disks? On Thu, Jun 15, 2023 at 3:22 PM Dave Page wrote: > > > On Thu, 15 Jun 2023 at 09:55, Sahil Harpal > wrote: > >> Hi Aditya

Re: Pgadmin4 System Stats Extension Design

2023-06-15 Thread Dave Page
On Thu, 15 Jun 2023 at 09:55, Sahil Harpal wrote: > Hi Aditya, > > Thank you for pointing this out. It would also be more convenient for > users to navigate to specific statistics easily. > > So, can we finalise the following design? > - Single dashboard with buttons to toggle between General (ex

Re: Pgadmin4 System Stats Extension Design

2023-06-15 Thread Sahil Harpal
Hi Aditya, Thank you for pointing this out. It would also be more convenient for users to navigate to specific statistics easily. So, can we finalise the following design? - Single dashboard with buttons to toggle between General (existing graphs/stats) and System Statistics. - Clubbing OS, CPU,

Re: Pgadmin4 System Stats Extension Design

2023-06-14 Thread Aditya Toshniwal
Hi Sahil, I would suggest club OS, CPU, Process, Disk and I/O in a tabbed control. (Taking inspiration from the task manager). It will reduce the network calls, cluttering and improve DOM performance. On Thu, Jun 15, 2023 at 11:08 AM Akshay Joshi wrote: > Hi Sahil > > On Thu, Jun 15, 2023 at 1

Re: Pgadmin4 System Stats Extension Design

2023-06-14 Thread Akshay Joshi
Hi Sahil On Thu, Jun 15, 2023 at 1:42 AM Sahil Harpal wrote: > Thank you, Akshay, for your feedback. > Here are a few more designs that I have created based on the discussion > with my mentors. I would love to know your thoughts on them. > > Design 1 - Using an additional new tab for system stat

Re: Pgadmin4 System Stats Extension Design

2023-06-13 Thread Akshay Joshi
Hi Sahil At first glance, it looks good to me. Seems you have created a new tab System Statistics instead of using the existing dashboard. On Tue, Jun 13, 2023 at 4:27 PM Sahil Harpal wrote: > Dear all, > > I am working on pgadmin4 to let users see their system-level statistics on > the dashboa