Re: PATCH: pgagent connection string parsing

2018-07-04 Thread Ashesh Vashi
On Wed, May 16, 2018 at 7:31 PM, Ashesh Vashi wrote: > [Adding pgadmin-hackers list...] > > Hi Team, > > Using the mutex around the logging code too to avoid overlapping log > message. > Please review it, and let me know your concern. > > Implementation details: > - Moved 'MutexLogger' class, whi

Re: PATCH: pgagent connection string parsing

2018-05-16 Thread Ashesh Vashi
[Adding pgadmin-hackers list...] Hi Team, Using the mutex around the logging code too to avoid overlapping log message. Please review it, and let me know your concern. Implementation details: - Moved 'MutexLogger' class, which was used by the connection management code only, in the include/misc.

Re: PATCH: pgagent connection string parsing

2017-08-21 Thread Thomas Krennwallner
On Mon Aug 21, 2017 09:47:47AM +0100, Dave Page wrote: > On Mon, Aug 21, 2017 at 9:46 AM, Ashesh Vashi wrote: > > On Mon, Aug 21, 2017 at 1:41 PM, Dave Page wrote: > >> Regardless of that, connection.cpp does need to be taught the correct > >> name for connect_timeout, as well as the additional a

Re: PATCH: pgagent connection string parsing

2017-08-21 Thread Dave Page
On Mon, Aug 21, 2017 at 9:46 AM, Ashesh Vashi wrote: > On Mon, Aug 21, 2017 at 1:41 PM, Dave Page wrote: > >> >> >> On Mon, Aug 21, 2017 at 6:24 AM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Aug 21, 2017 10:52, "Thomas Krennwallner" >>> wrote: >>> >>> On Mon Aug

Re: PATCH: pgagent connection string parsing

2017-08-21 Thread Ashesh Vashi
On Mon, Aug 21, 2017 at 1:41 PM, Dave Page wrote: > > > On Mon, Aug 21, 2017 at 6:24 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> >> >> On Aug 21, 2017 10:52, "Thomas Krennwallner" >> wrote: >> >> On Mon Aug 21, 2017 06:50:03AM +0530, Ashesh Vashi wrote: >> >On Aug 20, 201

Re: PATCH: pgagent connection string parsing

2017-08-21 Thread Dave Page
On Mon, Aug 21, 2017 at 6:24 AM, Ashesh Vashi wrote: > > > On Aug 21, 2017 10:52, "Thomas Krennwallner" > wrote: > > On Mon Aug 21, 2017 06:50:03AM +0530, Ashesh Vashi wrote: > >On Aug 20, 2017 22:48, "Thomas Krennwallner" <[1] > tk+pg...@postsubmeta.net> > >wrote: > > > > % ./pgage

Re: PATCH: pgagent connection string parsing

2017-08-20 Thread Ashesh Vashi
On Aug 21, 2017 10:52, "Thomas Krennwallner" wrote: On Mon Aug 21, 2017 06:50:03AM +0530, Ashesh Vashi wrote: >On Aug 20, 2017 22:48, "Thomas Krennwallner" <[1] tk+pg...@postsubmeta.net> >wrote: > > % ./pgagent -f -t60 -l2 dbname=xxx user=tkren connection_timeout=5 [...] > Sun

Re: PATCH: pgagent connection string parsing

2017-08-20 Thread Thomas Krennwallner
On Mon Aug 21, 2017 06:50:03AM +0530, Ashesh Vashi wrote: >On Aug 20, 2017 22:48, "Thomas Krennwallner" <[1]tk+pg...@postsubmeta.net> >wrote: > > % ./pgagent -f -t60 -l2 dbname=xxx user=tkren connection_timeout=5 [...] > Sun Aug 20 18:24:34 2017 : DEBUG: Creating DB connection:

Re: PATCH: pgagent connection string parsing

2017-08-20 Thread Ashesh Vashi
On Aug 20, 2017 22:48, "Thomas Krennwallner" wrote: Hi! I tried to pass the libpq parameter connect_timeout on the pgagent command-line without success: % ./pgagent -f -t60 -l2 dbname=xxx user=tkren connect_timeout=5 Sun Aug 20 18:24:26 2017 : DEBUG: Creating primary connection Sun Aug 20 18:2

PATCH: pgagent connection string parsing

2017-08-20 Thread Thomas Krennwallner
Hi! I tried to pass the libpq parameter connect_timeout on the pgagent command-line without success: % ./pgagent -f -t60 -l2 dbname=xxx user=tkren connect_timeout=5 Sun Aug 20 18:24:26 2017 : DEBUG: Creating primary connection Sun Aug 20 18:24:26 2017 : ERROR: Primary connection string is not va