Re: Discussion on improving alertify notifications logic

2017-07-31 Thread Murtuza Zabuawala
Hi, Looks good to me. Regards, Murtuza On Mon, Jul 31, 2017 at 2:59 PM, Ashesh Vashi wrote: > On Mon, Jul 31, 2017 at 2:54 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All >> > >> On Fri, Jul 28, 2017 at 1:51 PM, Dave Page wrote: >> >>> >>> >>> On Thu, Jul 27, 2017 at 2:4

Re: Discussion on improving alertify notifications logic

2017-07-31 Thread Ashesh Vashi
On Mon, Jul 31, 2017 at 2:54 PM, Akshay Joshi wrote: > Hi All > > On Fri, Jul 28, 2017 at 1:51 PM, Dave Page wrote: > >> >> >> On Thu, Jul 27, 2017 at 2:41 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi All >>> >>> As in commit "Update alertify alerts to use the styling d

Re: Discussion on improving alertify notifications logic

2017-07-31 Thread Akshay Joshi
Hi All On Fri, Jul 28, 2017 at 1:51 PM, Dave Page wrote: > > > On Thu, Jul 27, 2017 at 2:41 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All >> >> As in commit "Update alertify alerts to use the styling defined in >> the style guide": >> >> https://git.postgresql.org/gitweb

Re: Discussion on improving alertify notifications logic

2017-07-28 Thread Dave Page
On Thu, Jul 27, 2017 at 2:41 PM, Akshay Joshi wrote: > Hi All > > As in commit "Update alertify alerts to use the styling defined in > the style guide": > > https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commitdiff;h= > 2a30a86e7d5e562040500f448fbb0d143ff2cff9 > > https://git.postgresql.org/

Re: Discussion on improving alertify notifications logic

2017-07-27 Thread Akshay Joshi
Hi Sara On Fri, Jul 28, 2017 at 9:19 AM, Sarah McAlear wrote: > Hi Akshay! > > That seems like a good idea. When we're using the extended > pgadmin.alerrtify in the codebase it would be beneficial to call it > pgAdminAlertify or something similar so that it is clear that it isn't only > the aler

Re: Discussion on improving alertify notifications logic

2017-07-27 Thread Sarah McAlear
Hi Akshay! That seems like a good idea. When we're using the extended pgadmin.alerrtify in the codebase it would be beneficial to call it pgAdminAlertify or something similar so that it is clear that it isn't only the alertify library, but it's been extended. Rob & Sarah On Thu, Jul 27, 2017 at

Discussion on improving alertify notifications logic

2017-07-27 Thread Akshay Joshi
Hi All As in commit "Update alertify alerts to use the styling defined in the style guide": https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commitdiff ;h=2a30a86e7d5e562040500f448fbb0d143ff2cff9 https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commitdiff ;h=f2d2075d81718ec02550fb592851aa3