Re: Cleanup runtime qmake code

2020-05-04 Thread Dave Page
Hi On Mon, May 4, 2020 at 10:03 AM Akshay Joshi wrote: > Hi Dave > > Patch looks good to me except one small change in the README file that is > PGADMIN_PYTHON_PATH is mentioned but it should be PGADMIN_PYTHON_DIR > I kept mixing those up :-( I've committed the patch, and made a couple of chan

Re: Cleanup runtime qmake code

2020-05-04 Thread Akshay Joshi
Hi Dave Patch looks good to me except one small change in the README file that is PGADMIN_PYTHON_PATH is mentioned but it should be PGADMIN_PYTHON_DIR On Fri, May 1, 2020 at 8:29 PM Dave Page wrote: > The attached patch tidies up the qmake code for configuring the runtime > build so that it's c

Cleanup runtime qmake code

2020-05-01 Thread Dave Page
The attached patch tidies up the qmake code for configuring the runtime build so that it's consistent on all platforms, and simply requires that the PGADMIN_PYTHON_DIR environment variable points to the Python installation to be used. Please review, but don't commit, as this change will probably b