On Mon, Jun 11, 2018 at 3:59 PM, Ashesh Vashi wrote:
> Hi Team,
>
> On Sat, May 5, 2018 at 3:31 AM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> *...*
>> 3. Start the discussion on application architecture
>>
>> Why should we care about location of files inside a our appl
Hi Team,
On Sat, May 5, 2018 at 3:31 AM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> *...*
> 3. Start the discussion on application architecture
>
> Why should we care about location of files inside a our application?
>
> Why is this way better the another?
>
> These are 2 go
Hi Victoria,
On Thu, Jun 7, 2018 at 8:51 PM, Victoria Henry wrote:
> Hi Aditya
>
> Sure. I did not find moving web/pgadmin/tools/datagrid/static/js/datagrid.js.
>> Please correct me if I am missing anything.
>
> Generally speaking, I agree with moving/deleting files if it makes sense.
> But in r
Hi Aditya
Sure. I did not find moving
> web/pgadmin/tools/datagrid/static/js/datagrid.js. Please correct me if I am
> missing anything.
Generally speaking, I agree with moving/deleting files if it makes sense.
But in regards to web/pgadmin/tools/datagrid/static/js/datagrid.js, it
looks like this
Hi Victoria,
On Wed, Jun 6, 2018 at 8:55 PM, Victoria Henry wrote:
> Hi Aditya,
>
> 1) Why don't we start using webpack alias's instead of using absolute
>> path. For eg,
>> import {RestoreDialogWrapper} from '../../../pgadmin/static/js/
>> restore/restore_dialog_wrapper';
>> can be used as impo
Hi Aditya,
1) Why don't we start using webpack alias's instead of using absolute path.
> For eg,
> import {RestoreDialogWrapper} from
> '../../../pgadmin/static/js/restore/restore_dialog_wrapper';
> can be used as import {RestoreDialogWrapper} from
> 'pgadmin_static/js/restore/restore_dialog_wrapp
Hi Anthony/Victoria/Joao,
I know I am very late to review on patch 004. The idea of moving js files
from tools to static folder looks good, but I have a few suggestions:
1) Why don't we start using webpack alias's instead of using absolute path.
For eg,
import {RestoreDialogWrapper} from
'../../.
Hey Ashesh,
LGTM! The some of the CI tests failed but it looks like a flake. But you
can go ahead and merge this.
Sincerely,
Victoria
On Fri, Jun 1, 2018 at 2:36 PM Ashesh Vashi
wrote:
> On Fri, Jun 1, 2018 at 10:09 PM, Victoria Henry wrote:
>
>> Hi Ashesh,
>>
>> We just attempted to apply
Hi Ashesh,
We just attempted to apply your patch over master but it did not work. We
don't want to introduce any bugs or break any functionality. Please update
the patch to make sure it is synced up with the master branch.
Sincerely,
Victoria
On Fri, Jun 1, 2018 at 11:18 AM Anthony Emengo wr
Hey Ashesh,
Thanks for the explanation. It was great and it really helped!
C pgadmin/browser/server_groups/servers/databases/schemas/static/js/child.js
C
pgadmin/browser/server_groups/servers/databases/schemas/static/js/schema_child_tree_node.js
It makes sense to remove duplication by extractin
On Thu, May 24, 2018 at 8:13 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hey, Thanks so much for the reply.
>
> We've noticed that you've made several modifications on top of our
> original patch. Unfortunately, we've found it very hard to follow. Could we
> please get a b
All,
>
> These patches were first proposed on April 2 and the meaningful changes
> have yet to be committed. ~8 weeks is long enough that my assumption now is
> that these aren't going to be committed.
>
> The goal of these patches is to begin to separate out the ACI tree in
All,
These patches were first proposed on April 2 and the meaningful changes
have yet to be committed. ~8 weeks is long enough that my assumption now is
that these aren't going to be committed.
The goal of these patches is to begin to separate out the ACI tree in order
to allow us to do fe
Hey, Thanks so much for the reply.
We've noticed that you've made several modifications on top of our original
patch. Unfortunately, we've found it very hard to follow. Could we please
get a brief synopsis of the changes you have made - just so we can better
understand the rationale behind them? J
I spoke to Ashesh earlier - he's working on an update to the proposed patch
at the moment and will get back to you ASAP.
On Wed, May 23, 2018 at 3:14 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hello Hackers,
>
> Just to remind that if you need some more information from
Hello Hackers,
Just to remind that if you need some more information from our side you can
ping us.
Can we expect and email tomorrow morning with the commit?
Thanks
Victoria & Joao
On Mon, May 21, 2018 at 9:56 AM Dave Page wrote:
> Ashesh, please prioritise this so we can move on.
>
> Thanks.
Ashesh, please prioritise this so we can move on.
Thanks.
On Mon, May 21, 2018 at 2:46 PM, Anthony Emengo wrote:
> Hey all,
>
> We haven't heard from you all in a while regarding our last statements. Is
> there any thing that I need to clarify? We feel left in the dark here and
> just want to k
Hey all,
We haven't heard from you all in a while regarding our last statements. Is
there any thing that I need to clarify? We feel left in the dark here and
just want to know what we can do help.
Cheers!
Anthony && Joao
export function canCreate(pgBrowser, childOfCatalogType) {
return canCreateObject.bind({
browser: pgBrowser,
childOfCatalogType: childOfCatalogType,
});
}
With respect to the above code: this bind pattern looks good and seems like
the idiomatic way to handle this in JavaScript. On a li
Hi Joao,
On Tue, May 15, 2018 at 8:33 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hello Ashesh,
>
> These are our comments to the patch:
>
>
>-
>
>Can you explain the reasoning behind the change you did on the
>canCreate function?
>
> I do agree as Akshay ment
Hello Ashesh,
These are our comments to the patch:
-
Can you explain the reasoning behind the change you did on the canCreate
function?
Bind creates a new instance of a function, do we really need that?
-
isValidTreeNodeData
1. If it is not Null or Undefined it really mean
On Mon, May 14, 2018 at 6:10 PM, Dave Page wrote:
>
>
> On Mon, May 14, 2018 at 1:38 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Mon, May 14, 2018 at 2:59 PM, Dave Page wrote:
>>
>>>
>>>
>>> On Sat, May 12, 2018 at 12:10 AM, Ashesh Vashi <
>>> ashesh.va...@enterprisedb.com
On Mon, May 14, 2018 at 1:38 PM, Ashesh Vashi wrote:
> On Mon, May 14, 2018 at 2:59 PM, Dave Page wrote:
>
>>
>>
>> On Sat, May 12, 2018 at 12:10 AM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> On Sat, May 12, 2018, 02:58 Joao De Almeida Pereira <
>>> jdealmeidapere...@pivotal
On Mon, May 14, 2018 at 2:59 PM, Dave Page wrote:
>
>
> On Sat, May 12, 2018 at 12:10 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Sat, May 12, 2018, 02:58 Joao De Almeida Pereira <
>> jdealmeidapere...@pivotal.io> wrote:
>>
>>> Hello Ashesh,
>>>
>>> 1. In TreeNode, we're ke
On Sat, May 12, 2018 at 12:10 AM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:
> On Sat, May 12, 2018, 02:58 Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hello Ashesh,
>>
>> 1. In TreeNode, we're keepging the reference of DOMElement, do we really
need it?
>>>
On Sat, May 12, 2018, 02:58 Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hello Ashesh,
>
> 1. In TreeNode, we're keepging the reference of DOMElement, do we really
>>> need it?
>>
>> As of right now, our Tree abstraction acts as an adapter to the aciTree
>>> library. The aciTre
Hello Ashesh,
1. In TreeNode, we're keepging the reference of DOMElement, do we really
>> need it?
>
> As of right now, our Tree abstraction acts as an adapter to the aciTree
>> library. The aciTree library needs the domElement for most of its functions
>> (setInode, unload, etc). Thus this is the
On Thu, May 10, 2018 at 8:08 PM, Anthony Emengo wrote:
> 1. In TreeNode, we're keepging the reference of DOMElement, do we really
>> need it?
>
> As of right now, our Tree abstraction acts as an adapter to the aciTree
> library. The aciTree library needs the domElement for most of its functions
>
nsidered separately.
>>>>
>>>> So given Anthony's comments, are you happy with this patch?
>>>>
>>> I liked the design so far.
>>> But - as Khushboo mentioned ealier - it is missing at some places.
>>> I had to read through the code to
d the execution flow for some.
>>
>> And, there is still a lot missing bits, and pieces to consider for commit
>> in the repo.
>>
>> -- Thanks, Ashesh
>>
>>>
>>>
>>>>
>>>> -- Thanks, Ashesh
>>>>
>>>&g
>
>>
>>
>>>
>>> -- Thanks, Ashesh
>>>
>>>>
>>>> Anthony && Joao
>>>>
>>>> On Mon, Apr 30, 2018 at 11:03 AM, Ashesh Vashi <
>>>> ashesh.va...@enterprisedb.com> wrote:
>>>>
&g
; On Mon, Apr 30, 2018 at 11:03 AM, Ashesh Vashi <
>>> ashesh.va...@enterprisedb.com> wrote:
>>>
>>>>
>>>>
>>>>
>>>> On Mon, Apr 30, 2018 at 8:30 PM, Ashesh Vashi <
>>>> ashesh.va...@enterprisedb.com> wrote:
&g
t;>> On Sat, Apr 28, 2018 at 3:55 AM, Joao De Almeida Pereira <
>>>> jdealmeidapere...@pivotal.io> wrote:
>>>>
>>>>> Hi Hackers,
>>>>> As you are aware we kept on working on the patch, so we are attaching
>>>>> to this
i Hackers,
>>>> As you are aware we kept on working on the patch, so we are attaching
>>>> to this email a new version of the patch.
>>>> This new version contains all the changes in the previous one plus more
>>>> extractions of functions and refactoring
on working on the patch, so we are attaching to
>>> this email a new version of the patch.
>>> This new version contains all the changes in the previous one plus more
>>> extractions of functions and refactoring of code.
>>>
>>> The objective of this patch
new version of the patch.
>> This new version contains all the changes in the previous one plus more
>> extractions of functions and refactoring of code.
>>
>> The objective of this patch is to create a separation between pgAdmin and
>> the ACI Tree. We are doing this be
previous one plus more
> extractions of functions and refactoring of code.
>
> The objective of this patch is to create a separation between pgAdmin and
> the ACI Tree. We are doing this because we realized that at this point in
> time we have the ACI Tree all over the code of pgAd
On Mon, Apr 30, 2018 at 3:51 PM, Anthony Emengo wrote:
> Hi there,
>
> Yes, there's a lot of TODO that we intend for this effort - to be
> submitted. We'd like to remove as much *direct* invocations on the ACI
> Tree library, as it causes a lot of coupling to the libra
Hi there,
Yes, there's a lot of TODO that we intend for this effort - to be
submitted. We'd like to remove as much *direct* invocations on the ACI Tree
library, as it causes a lot of coupling to the library. It is not the final
patch, but we cannot come up with a definitive list of the
previous one plus more
> extractions of functions and refactoring of code.
>
> The objective of this patch is to create a separation between pgAdmin and
> the ACI Tree. We are doing this because we realized that at this point in
> time we have the ACI Tree all over the code of pgAd
ly because this is going to be a very big patch with a very big
>>>>> number of changes.
>>>>>
>>>>>>
>>>>>> Thanks
>>>>>>> Joao
>>>>>>>
>>>>>>>
>>>>>>>
gt;>>>>>
>>>>>>> Hi Joao,
>>>>>>>
>>>>>>> Patch looks good and working as expected.
>>>>>>>
>>>>>>> I also agree with Dave, Can we please add some comments in each file
>>>>>
>>>>>> I also agree with Dave, Can we please add some comments in each file
>>>>>> which can help us to understand the flow, I'm saying because now the code
>>>>>> is segregated in so many separate files it will be hard to keep track of
>>
gt;>>> --
>>>>> Regards,
>>>>> Murtuza Zabuawala
>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>>
>>>>> On Thu, Apr 5, 2018 at 7:08 PM, Joao De A
hushboo,
>>>>> Attached you can find both patches rebased
>>>>>
>>>>> Thanks
>>>>>
>>>>>
>>>>> On Thu, Apr 5, 2018 at 6:31 AM Khushboo Vashi <
>>>>> khushboo.va...@enterprisedb.com> wrote:
&g
gt;>>>> Thanks,
>>>>> Khushboo
>>>>>
>>>>>
>>>>> On Tue, Apr 3, 2018 at 12:15 AM, Joao De Almeida Pereira <
>>>>> jdealmeidapere...@pivotal.io> wrote:
>>>>>
>>>>>> Hi Hack
start to decouple pgAdmin
>>>>> from ACITree library.
>>>>> This patch is intended to be merged after 3.0, because we do not want
>>>>> to cause any entropy or delay the release, but we want to start the
>>>>> discussion and show some cod
e pgAdmin
>>>> from ACITree library.
>>>> This patch is intended to be merged after 3.0, because we do not want
>>>> to cause any entropy or delay the release, but we want to start the
>>>> discussion and show some code.
>>>>
>>>
(Test double, for reference on the available test
>>> doubles: https://martinfowler.com/bliki/TestDouble.html) that can be
>>> used to inplace to replace the ACITree and also encapsulate the new tree
>>> behavior on our tests
>>> - Adds tests for all the tree funct
love the help of the community to do it.
>
> *Summary of the patch:*
> 0001 patch:
> - Creates a new tree that will allow us to create a separation between
> the application and ACI Tree
> - Creates a Fake Tree (Test double, for reference on the available test
> doubles: ht
> and show some code.
>>
>> This job that we started is a massive tech debt chore that will take some
>> time to finalize and we would love the help of the community to do it.
>>
>> *Summary of the patch:*
>> 0001 patch:
>> - Creates a new tree that w
community to do it.
>
> *Summary of the patch:*
> 0001 patch:
> - Creates a new tree that will allow us to create a separation between
> the application and ACI Tree
> - Creates a Fake Tree (Test double, for reference on the available test
> doubles: https://martinfowler.com/
nt:0
>9. tigger_count:"0"
>10. _id:831144
>11. _pid:24579
>12. _type:"table"
>
> - This amount of information take around 12 seconds to be displayed
> *- It is pretty hard to find something in set off 8k tables*
>
> We started looking into pos
tty hard to find something in set off 8k tables*
We started looking into possibilities to solve this issue, but we bumped
into the ACI Tree again and the way ACI Tree is so ingrained into our code.
In order to try to create a better experience to these users these are the
steps that we believe need to be do
Hackers,
We have multiple end users who have in excess of 10 thousand of tables in a
single schema. Currently this causes pgAdmin to choke.
The major issue we are seeing is that the ACI tree is unsupported and it
seems to be the backbone of pgAdmin 4.
Is anyone else having this issue? Is there
;> Which will call to method def statistics(...) method
>>>
>>> *'dependency'* - Displays object dependencies on Dependencies panel
>>> Which will call to method def dependencies(...) method
>>>
>>> *'dependent'* - Displays object de
hich will call to method def dependencies(...) method
>>
>> *'dependent'* - Displays object dependents on SQL panel
>> Which will call to method def dependents(...) method
>>
>> Hope that helps.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>
gt; EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Fri, Feb 23, 2018 at 9:08 PM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hello Hackers,
>> Need some pointers while creating new node on ACI Tree.
>
ject dependents on SQL panel
Which will call to method def dependents(...) method
Hope that helps.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Fri, Feb 23, 2018 at 9:08 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivo
Hello Hackers,
Need some pointers while creating new node on ACI Tree.
In GreenPlum there is a concept of External Tables that are more or less
similar to Foreign Wrappers, but different. So we started implementing a
new node for it.
We copied the Foreign Wrappers node and started it playing with
Hi
On Tue, Feb 20, 2018 at 5:16 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hello,
> It is to make it clear which shortcut test is failing, something similar
> to the query tool tests.
>
Ah.
>
> If you want I can separate those in 2 separate patches
>
No need - I comm
Hello,
It is to make it clear which shortcut test is failing, something similar to
the query tool tests.
If you want I can separate those in 2 separate patches
Thanks
Joao
On Tue, Feb 20, 2018 at 12:05 PM Dave Page wrote:
> Hi
>
> On Tue, Feb 20, 2018 at 4:51 PM, Joao De Almeida Pereira <
> jd
Hi
On Tue, Feb 20, 2018 at 4:51 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hello Dave,
> No there is only tests around the the backendsupport function
>
Let me rephrase :-). What's this part of the patch for?
--- a/web/pgadmin/feature_tests/keyboard_shortcut_test.py
++
Hello Dave,
No there is only tests around the the backendsupport function
Thanks
Joao
On Mon, Feb 19, 2018 at 6:08 AM Dave Page wrote:
> Hi
>
> On Mon, Feb 12, 2018 at 6:30 PM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hi Hackers
>>
>> The attached patch implements t
Hi
On Mon, Feb 12, 2018 at 6:30 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hi Hackers
>
> The attached patch implements the feature #3107 to hide the tablespaces on
> GreenPlum databases.
>
Did you accidentally include some keyboard shortcut test code in this
patch?
-
Hi Hackers
The attached patch implements the feature #3107 to hide the tablespaces on
GreenPlum databases.
Thanks
Joao
hide-tablespaces-for-greenplum.diff
Description: Binary data
t; Hi Hackers,
>
> Attached is a patch that makes ACI tree works better with Greenplum.
>
> When connected to a Greenplum database server
> - Hide items that not work with GPDB, such as Triggers, FDW, FTS_*, etc
> - Tables/Views/Catalogs/Language node can expand correctly
> -
Hi Hackers,
Attached is a patch that makes ACI tree works better with Greenplum.
When connected to a Greenplum database server
- Hide items that not work with GPDB, such as Triggers, FDW, FTS_*, etc
- Tables/Views/Catalogs/Language node can expand correctly
- Views/Languages/Catalogs can show
68 matches
Mail list logo
