Thanks patch applied.
On Tue, Aug 27, 2019 at 2:42 PM Shubham Agarwal <
shubham.agar...@enterprisedb.com> wrote:
> Hi Akshay,
>
> PFA the patch with fixed review comments.
>
> On Thu, Aug 22, 2019 at 4:26 PM Shubham Agarwal <
> shubham.agar...@enterprisedb.com> wrote:
>
>> Yes, I agreed too.
>> T
Hi Akshay,
PFA the patch with fixed review comments.
On Thu, Aug 22, 2019 at 4:26 PM Shubham Agarwal <
shubham.agar...@enterprisedb.com> wrote:
> Yes, I agreed too.
> The only thinking was if the test case objective is to check the debugger,
> then it should fail instead of skipping it to come i
On Thu, Aug 22, 2019 at 2:41 PM Ashesh Vashi
wrote:
> Akshay,
>
> On Thu, Aug 22, 2019 at 2:29 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Nice work!
>>
> It's big patch, and also improvement over last status.
> Can we commit the patch, as to avoid any merging issues later?
>
Yes, I agreed too.
The only thinking was if the test case objective is to check the debugger,
then it should fail instead of skipping it to come into direct notice.
If the only test case for debugger gets skip, then the functionality will
never be tested.
On Thu, Aug 22, 2019 at 4:06 PM Ashesh Vas
On Thu, Aug 22, 2019 at 4:04 PM Dave Page wrote:
>
>
> On Thu, Aug 22, 2019 at 11:26 AM Shubham Agarwal <
> shubham.agar...@enterprisedb.com> wrote:
>
>> Hi Akshay,
>> Thanks for the overall review and comments.
>>
>> From the logs and screenshot shared by you, it is cleared that the
>> debugger
On Thu, Aug 22, 2019 at 11:26 AM Shubham Agarwal <
shubham.agar...@enterprisedb.com> wrote:
> Hi Akshay,
> Thanks for the overall review and comments.
>
> From the logs and screenshot shared by you, it is cleared that the
> debugger plugin is not installed for PG12 server, hence resulting in the
>
Hi Akshay,
Thanks for the overall review and comments.
>From the logs and screenshot shared by you, it is cleared that the debugger
plugin is not installed for PG12 server, hence resulting in the failures of
"xss_checks_pgadmin_debugger_test.py" test case.
Please install and re-execute the test ca
On Thu, Aug 22, 2019 at 2:43 PM Akshay Joshi
wrote:
>
>
> On Thu, Aug 22, 2019 at 2:41 PM Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Akshay,
>>
>> On Thu, Aug 22, 2019 at 2:29 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Nice work!
>>>
>> It's big patch, and
Akshay,
On Thu, Aug 22, 2019 at 2:29 PM Akshay Joshi
wrote:
> Nice work!
>
It's big patch, and also improvement over last status.
Can we commit the patch, as to avoid any merging issues later?
-- Thanks, Ashesh
>
> I have run the feature test couple of times on EPAS 9.6, 11, 12 and PG
> 9.4, 1
Nice work!
I have run the feature test couple of times on EPAS 9.6, 11, 12 and PG 9.4,
10, 11, 12. Following are the review comments:
- Following test cases are failing every time on *EPAS 12:*
- Explain query with JIT stats... fails with error "*no such element:
Unable to locate e
No, we are looking into it.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Mon, Jan 22, 2018 at 6:56 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hello Hackers,
> Is the latest commit in master passing the Fea
Hello Hackers,
Is the latest commit in master passing the Feature tests?
Thanks
Joao
12 matches
Mail list logo
