Re: [pgadmin4][patch] Use ESLinter options instead of using Javascript

2018-05-16 Thread Ashesh Vashi
On Thu, May 17, 2018 at 11:05 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Anthony, > > The code looks good to me and working fine. > > Thanks, > Khushboo > > > On Wed, May 16, 2018 at 9:23 PM, Anthony Emengo > wrote: > >> Hey all, we'd definitely like some feedback on this p

Re: [pgadmin4][patch] Use ESLinter options instead of using Javascript

2018-05-16 Thread Khushboo Vashi
Hi Anthony, The code looks good to me and working fine. Thanks, Khushboo On Wed, May 16, 2018 at 9:23 PM, Anthony Emengo wrote: > Hey all, we'd definitely like some feedback on this patch. Does does it > not apply cleanly? Do we need to resend it? > > Thanks > Anthony > > On Mon, May 14, 2018

Re: [pgadmin4][patch] Use ESLinter options instead of using Javascript

2018-05-16 Thread Anthony Emengo
Hey all, we'd definitely like some feedback on this patch. Does does it not apply cleanly? Do we need to resend it? Thanks Anthony On Mon, May 14, 2018 at 3:47 PM Anthony Emengo wrote: > Apologies, here's a redo that should apply cleanly on top of master > > Anthony && Joao > > On Mon, May 14,

Re: [pgadmin4][patch] Use ESLinter options instead of using Javascript

2018-05-14 Thread Anthony Emengo
Apologies, here's a redo that should apply cleanly on top of master Anthony && Joao On Mon, May 14, 2018 at 3:25 PM Anthony Emengo wrote: > Hi Hackers, > > Attached you can find a patch that changes the way we are running ESLint > on the Javascript files. Instead of using Javascript we can use

[pgadmin4][patch] Use ESLinter options instead of using Javascript

2018-05-14 Thread Anthony Emengo
Hi Hackers, Attached you can find a patch that changes the way we are running ESLint on the Javascript files. Instead of using Javascript we can use ESLint parameters to archive the same goal. In the future this will also allow us to use the rest of the cli parameters like (--fix and others...)