Re: [pgadmin4][patch] Hides the tablespace node in ACI tree for GreenPlum

2018-02-20 Thread Dave Page
Hi On Tue, Feb 20, 2018 at 5:16 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello, > It is to make it clear which shortcut test is failing, something similar > to the query tool tests. > Ah. > > If you want I can separate those in 2 separate patches > No need - I comm

Re: [pgadmin4][patch] Hides the tablespace node in ACI tree for GreenPlum

2018-02-20 Thread Joao De Almeida Pereira
Hello, It is to make it clear which shortcut test is failing, something similar to the query tool tests. If you want I can separate those in 2 separate patches Thanks Joao On Tue, Feb 20, 2018 at 12:05 PM Dave Page wrote: > Hi > > On Tue, Feb 20, 2018 at 4:51 PM, Joao De Almeida Pereira < > jd

Re: [pgadmin4][patch] Hides the tablespace node in ACI tree for GreenPlum

2018-02-20 Thread Dave Page
Hi On Tue, Feb 20, 2018 at 4:51 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Dave, > No there is only tests around the the backendsupport function > Let me rephrase :-). What's this part of the patch for? --- a/web/pgadmin/feature_tests/keyboard_shortcut_test.py ++

Re: [pgadmin4][patch] Hides the tablespace node in ACI tree for GreenPlum

2018-02-20 Thread Joao De Almeida Pereira
Hello Dave, No there is only tests around the the backendsupport function Thanks Joao On Mon, Feb 19, 2018 at 6:08 AM Dave Page wrote: > Hi > > On Mon, Feb 12, 2018 at 6:30 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Hackers >> >> The attached patch implements t

Re: [pgadmin4][patch] Hides the tablespace node in ACI tree for GreenPlum

2018-02-19 Thread Dave Page
Hi On Mon, Feb 12, 2018 at 6:30 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers > > The attached patch implements the feature #3107 to hide the tablespaces on > GreenPlum databases. > Did you accidentally include some keyboard shortcut test code in this patch? -

[pgadmin4][patch] Hides the tablespace node in ACI tree for GreenPlum

2018-02-12 Thread Joao De Almeida Pereira
Hi Hackers The attached patch implements the feature #3107 to hide the tablespaces on GreenPlum databases. Thanks Joao hide-tablespaces-for-greenplum.diff Description: Binary data