Re: [pgadmin][patch] Electron version 4.X

2018-06-17 Thread Dave Page
Hi On Fri, Jun 8, 2018 at 3:49 PM, Victoria Henry wrote: > - I think the build instructions need to be more generic (particularly on >> macOS). For example, I do not use HomeBrew (largely due to some nasty >> security issues they had in the past). I was able to mostly port the >> instructions a

Re: [pgadmin][patch] Electron version 4.X

2018-06-13 Thread Dave Page
Hi On Tue, Jun 12, 2018 at 8:04 PM, Victoria Henry wrote: > Hi Hackers, > > Attached is a revised patch with the following changes: > >- updated the README >- moved the build scripts to the pkg folder >- storing the out files in dist/arch/ >- fix the mac build so it no longer sta

Re: [pgadmin][patch] Electron version 4.X

2018-06-11 Thread Dave Page
Hi On Fri, Jun 8, 2018 at 3:49 PM, Victoria Henry wrote: > > > On Tue, Jun 5, 2018 at 12:28 PM Dave Page wrote: > >> Hi >> >> On Mon, Jun 4, 2018 at 10:27 PM, Joao De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: >> >>> Hi Hackers, >>> >>> Attached you can find the patch that introd

Re: [pgadmin][patch] Electron version 4.X

2018-06-08 Thread Victoria Henry
On Tue, Jun 5, 2018 at 12:28 PM Dave Page wrote: > Hi > > On Mon, Jun 4, 2018 at 10:27 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Hackers, >> >> Attached you can find the patch that introduces electron to our code base. >> > Cool. FYI, I'd like to get this into r

Re: [pgadmin][patch] Electron version 4.X

2018-06-06 Thread Murtuza Zabuawala
Hi Joao, Awesome job, I tried windows build & it is running very smooth on my Win10 VM, It took some time when I ran it for the first time (I think because it ran "update.exe") but it was quick when opened second time onwards (taking ~6-7 secs to display the main window). The main thing I notice

Re: [pgadmin][patch] Electron version 4.X

2018-06-05 Thread Dave Page
Hi On Mon, Jun 4, 2018 at 10:27 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > Attached you can find the patch that introduces electron to our code base. > Cool. FYI, I'd like to get this into rough shape and then push it to a dev branch for fine-tuning. I th