Re: [pgAdmin4] RM5965 Couldn't download file of Marcos query results

2020-12-13 Thread Akshay Joshi
Thanks, patch applied. On Mon, Dec 14, 2020 at 11:55 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Rahul, > > The file in the patch - > *web/regression/javascript/sqleditor/query_tool_preferences.js* is a copy > of *web/pgadmin/static/js/sqleditor/query_tool_preferences.js*

Re: [pgAdmin4] RM5965 Couldn't download file of Marcos query results

2020-12-13 Thread Aditya Toshniwal
Hi Rahul, The file in the patch - *web/regression/javascript/sqleditor/query_tool_preferences.js* is a copy of *web/pgadmin/static/js/sqleditor/query_tool_preferences.js* and is not a test case file. @committer - Please remove the file *web/regression/javascript/sqleditor/query_tool_preferences.j

Re: [pgAdmin4] RM5965 Couldn't download file of Marcos query results

2020-12-09 Thread Aditya Toshniwal
Hello Rahul, Found below issues: 1) The data grid is not fetching more than 1000 records now, gives a console error: sqleditor.js:1264 Uncaught TypeError: self.enable_disable_download_btn is not a function at child.fetch_next (sqleditor.js:1264) 2) The sqleditor test cases are failing. 3) Fix

Re: [pgAdmin4] RM5965 Couldn't download file of Marcos query results

2020-12-09 Thread Akshay Joshi
Hi Aditya Can you please review this patch? On Mon, Dec 7, 2020 at 3:10 PM Rahul Shirsat wrote: > Hi Hackers, > > Please find the updated patch below. > > On Mon, Dec 7, 2020 at 2:55 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patc