Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

Thanks patch applied. On Thu, Jan 24, 2019 at 4:19 PM Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch to fix dialog tab navigation in backup and > restore dialog. > > Note: If first control in dialog is bootstrap switch then tab and dialog > tab navig

Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

Hi, Please find attached patch to fix dialog tab navigation in backup and restore dialog. Note: If first control in dialog is bootstrap switch then tab and dialog tab navigation do not work. This is because bootstrap switch captures all keyboard events and it does not allow them to propagate /bub

Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

Thanks patch applied. On Tue, Jan 22, 2019 at 2:51 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > The patch looks good to me. > > On Mon, Jan 21, 2019 at 4:39 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> Can you please review it. >> >> On Wed, Ja

Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

The patch looks good to me. On Mon, Jan 21, 2019 at 4:39 PM Akshay Joshi wrote: > Hi Khushboo > > Can you please review it. > > On Wed, Jan 16, 2019 at 12:55 PM Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> Please find attached updated patch. >> In this patch I have f

Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

Hi Khushboo Can you please review it. On Wed, Jan 16, 2019 at 12:55 PM Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached updated patch. > In this patch I have fixed two issues: > i. Dialog tab navigation should work even if focus is on footer buttons > (Save

Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

Hi, Please find attached updated patch. In this patch I have fixed two issues: i. Dialog tab navigation should work even if focus is on footer buttons (Save, Cancel, etc..) ii. Focus should be set to first editable element of dialog when tab cycle goes through all editable footer buttons. -- *H

[pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

Hi, This patch fixes Dialog tabset keyboard navigation. This regression was caused due to bootstrap 4 changes. Also I have added jasmine test cases for the same -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --g