Re: [pgAdmin4][patch] SQL Keywords extract utility

2019-03-20 Thread Dave Page
Thanks - I've committed that, with a minor change to print the total at the end in a nice friendly format. On Wed, Mar 20, 2019 at 10:21 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch. Changes include, > 1) I have added a new requir

Re: [pgAdmin4][patch] SQL Keywords extract utility

2019-03-20 Thread Aditya Toshniwal
Hi Hackers, Attached is the updated patch. Changes include, 1) I have added a new requirements.txt file under pgadmin/tools for requirements specific to utilities. 2) As suggested by Dave, I have pulled the release version from https://www.postgresql.org/docs/current/index.html and used it to pull

Re: [pgAdmin4][patch] SQL Keywords extract utility

2019-03-20 Thread Dave Page
Hi On Wed, Mar 20, 2019 at 8:21 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Tue, Mar 19, 2019 at 9:46 PM Dave Page wrote: > >> Hi >> >> On Tue, Mar 19, 2019 at 10:43 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Att

Re: [pgAdmin4][patch] SQL Keywords extract utility

2019-03-20 Thread Aditya Toshniwal
Hi, On Tue, Mar 19, 2019 at 9:46 PM Dave Page wrote: > Hi > > On Tue, Mar 19, 2019 at 10:43 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is a small utility which help in getting the SQL keywords used >> by PostgreSQL and pl/pgsql. >> Note that

Re: [pgAdmin4][patch] SQL Keywords extract utility

2019-03-19 Thread Dave Page
Hi On Tue, Mar 19, 2019 at 10:43 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a small utility which help in getting the SQL keywords used by > PostgreSQL and pl/pgsql. > Note that, for pgsql code path is required as keywords are not available > in

[pgAdmin4][patch] SQL Keywords extract utility

2019-03-19 Thread Aditya Toshniwal
Hi Hackers, Attached is a small utility which help in getting the SQL keywords used by PostgreSQL and pl/pgsql. Note that, for pgsql code path is required as keywords are not available in any docs. So, the code paths may need to change with new release of PostgreSQL. For PostgrSQL keywords, it wil