Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

2019-02-04 Thread Akshay Joshi
Thanks patch applied. On Mon, Feb 4, 2019 at 5:36 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix jasmine test cases. Didn't realise the > timezones could create issues :( > Kindly review. > > On Mon, Feb 4, 2019 at 4:17 PM Aditya Tos

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

2019-02-04 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix jasmine test cases. Didn't realise the timezones could create issues :( Kindly review. On Mon, Feb 4, 2019 at 4:17 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to change the dashboard test cases t

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

2019-02-04 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to change the dashboard test cases to fetch server_id similar to how it is done in other test cases. Kindly review. On Mon, Feb 4, 2019 at 3:43 PM Akshay Joshi wrote: > Thanks patch applied. > > On Mon, Feb 4, 2019 at 3:27 PM Aditya Toshniwal < > aditya.toshni

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

2019-02-04 Thread Akshay Joshi
Thanks patch applied. On Mon, Feb 4, 2019 at 3:27 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch. The poller will wait 3 times the normal > interval before sending new request if the previous request is pending. > After that, it wil

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

2019-02-04 Thread Dave Page
On Mon, Feb 4, 2019 at 10:10 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Mon, Feb 4, 2019 at 3:36 PM Dave Page wrote: > >> Hi >> >> Do we also give up waiting for the original response? >> > No, that will wait until AJAX request timeout. We do not cancel it >

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

2019-02-04 Thread Aditya Toshniwal
Hi Dave, On Mon, Feb 4, 2019 at 3:36 PM Dave Page wrote: > Hi > > Do we also give up waiting for the original response? > No, that will wait until AJAX request timeout. We do not cancel it explicitly. If response is received, it will be reflected. > > On Mon, Feb 4, 2019 at 9:57 AM Aditya Toshn

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

2019-02-04 Thread Dave Page
Hi Do we also give up waiting for the original response? On Mon, Feb 4, 2019 at 9:57 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch. The poller will wait 3 times the normal > interval before sending new request if the previous requ

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

2019-02-04 Thread Aditya Toshniwal
Hi Hackers, Attached is the updated patch. The poller will wait 3 times the normal interval before sending new request if the previous request is pending. After that, it will send the ajax. Kindly review. On Mon, Feb 4, 2019 at 3:12 PM Dave Page wrote: > I can't get to this right now, but Aksh

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

2019-02-04 Thread Dave Page
I can't get to this right now, but Akshay, can we get it in before the release? I don't think the problem Khushboo notes is really a problem. Waiting for a response before issuing another one seems sensible... as long as there's a timeout so things don't get stuck if a response gets lost somehow.

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

2019-02-04 Thread Khushboo Vashi
Hi Aditya, I have reviewed the patch and it looks good to me except the logic to wait until we get the response from the AJAX request. So, in this case at a time only one request is being sent to the server. @ Dave/Ashesh, if you think this is okay then we can commit the patch. Thanks, Khushboo

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

2019-02-03 Thread Akshay Joshi
Hi Khushboo Can you please review it. On Fri, Feb 1, 2019 at 7:04 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to optimise the dashboard. Changes include: > 1) One ajax request for the all the charts instead of separate for every > chart

[pgAdmin4][RM3941] Dashboard graphs needs optimizations

2019-02-01 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to optimise the dashboard. Changes include: 1) One ajax request for the all the charts instead of separate for every chart. The next request will not hit until the previous is completed. 2) The code will check for intervals which is greatest common divisor of all