Re: [pgAdmin4][RM3562] Migrate Bootstrap 3 to Bootstrap 4

2018-10-11 Thread Dave Page
Thanks, applied. On Thu, Oct 11, 2018 at 12:52 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is part 3 of the patch, to be applied after part 2. Urgh, I know > this is annoying, but I am trying to fix and send patches as and when I > find them. This pa

Re: [pgAdmin4][RM3562] Migrate Bootstrap 3 to Bootstrap 4

2018-10-11 Thread Dave Page
Thanks, applied. On Thu, Oct 11, 2018 at 11:08 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Team found few more issues. Calendar control totally messed up. The > bootstrap-datetimepicker package does not work with Bootstrap 4. > Fortunately, there exists one p

Re: [pgAdmin4][RM3562] Migrate Bootstrap 3 to Bootstrap 4

2018-10-11 Thread Aditya Toshniwal
Hi Hackers, Attached is part 3 of the patch, to be applied after part 2. Urgh, I know this is annoying, but I am trying to fix and send patches as and when I find them. This patch includes fix for hiding controls. Backform used "hidden" class for hiding elements, and hidden is replaced with d-none

Re: [pgAdmin4][RM3562] Migrate Bootstrap 3 to Bootstrap 4

2018-10-11 Thread Aditya Toshniwal
Hi Hackers, Team found few more issues. Calendar control totally messed up. The bootstrap-datetimepicker package does not work with Bootstrap 4. Fortunately, there exists one package which is advanced version of the same - https://tempusdominus.github.io/bootstrap-4/. With minimum changes I am abl

Re: [pgAdmin4][RM3562] Migrate Bootstrap 3 to Bootstrap 4

2018-10-10 Thread Dave Page
Thanks, patch applied. On Wed, Oct 10, 2018 at 11:41 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Ohh :/ > Attached is the rebased patch - v4. > > On Wed, Oct 10, 2018 at 3:55 PM Dave Page wrote: > >> Hi >> >> Did you rebase this? It doesn't apply for me: >> >> (pgadmin4) d

Re: [pgAdmin4][RM3562] Migrate Bootstrap 3 to Bootstrap 4

2018-10-10 Thread Dave Page
Hi Did you rebase this? It doesn't apply for me: (pgadmin4) dpage@hal:*~/git/pgadmin4*$ git apply ~/Downloads/RM3562_v3.patch error: patch failed: web/pgadmin/static/scss/_select2.overrides.scss:2 error: web/pgadmin/static/scss/_select2.overrides.scss: patch does not apply /Users/dpage/Downloa

Re: [pgAdmin4][RM3562] Migrate Bootstrap 3 to Bootstrap 4

2018-10-09 Thread Dave Page
Hi Almost there - unfortunately I found another couple of issues in server mode (placement of the username, and formatting of the menu). Please see the attached screenshot. Regards, Dave. On Tue, Oct 9, 2018 at 10:13 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers,

Re: [pgAdmin4][RM3562] Migrate Bootstrap 3 to Bootstrap 4

2018-10-08 Thread Aditya Toshniwal
Hi, On Mon, Oct 8, 2018 at 4:06 PM Dave Page wrote: > Hi > > On Fri, Oct 5, 2018 at 1:51 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to migrate pgAdmin4 currently based on Bootstrap 3, >> to be Bootstrap 4 compatible. The idea is