Re: [pgAdmin4][RM3136] Stabilise feature tests for continuous running on CI sytems

2018-10-03 Thread Dave Page
Thanks, patch applied. Let's see what happens now :-) On Wed, Oct 3, 2018 at 6:40 AM Usman Muzaffar < usman.muzaf...@enterprisedb.com> wrote: > Hi Hackers, > > Please find here attached patch for RM3136. It provides fixes for the > following two test cases > > >- pg_utilities_backup_restore_t

Re: [pgAdmin4][RM3136] Stabilise feature tests for continuous running on CI sytems

2018-10-02 Thread Usman Muzaffar
Hi Hackers, Please find here attached patch for RM3136. It provides fixes for the following two test cases - pg_utilities_backup_restore_test.py - pg_utilities_maintenance_test.py The fixes include the followings - Added the code to skip the assertion check for backup file name for wi

Re: [pgAdmin4][RM3136] Stabilise feature tests for continuous running on CI sytems

2018-09-10 Thread Dave Page
Thanks, patch applied (I've removed a screenshot call that seemed to be left there by mistake). On Fri, Sep 7, 2018 at 5:47 PM, Usman Muzaffar < usman.muzaf...@enterprisedb.com> wrote: > Hi Hackers, > > Please find here attached patch for query_tool_tests.py. On > Jenkins(windows platform), the t

Re: [pgAdmin4][RM3136] Stabilise feature tests for continuous running on CI sytems

2018-09-07 Thread Usman Muzaffar
Hi Hackers, Please find here attached patch for query_tool_tests.py. On Jenkins(windows platform), the test case was failing due to conflict for Explain Option drop down which was not closed. I have added the code on the required places and verified on all platforms. Please review the patch and c

Re: [pgAdmin4][RM3136] Stabilise feature tests for continuous running on CI sytems

2018-08-21 Thread Akshay Joshi
Thanks patch applied with following changes: - Remove "*self._screenshot()" *method from each feature test as it will take screenshot every time even though test case will execute successfully. - Fix pep8 issues. - Remove unnecessary blank lines. - Change function name from "setT

[pgAdmin4][RM3136] Stabilise feature tests for continuous running on CI sytems

2018-08-20 Thread Usman Muzaffar
Hi Hackers, Attached is the patch for feature tests, mostly fix issues due to which test cases were failing on jenkins. It has the following fixes, - Added code to Create testing db node from runtests.py with random number in name to avoid naming conflicts in parallel execution on differen