Re: [pgAdmin4][RM2586] Cleanup feature test

2017-08-29 Thread Dave Page
Thanks, patch applied (test time now down to 209s :-) ). On Mon, Aug 28, 2017 at 11:04 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached updated patch > > On Fri, Aug 25, 2017 at 2:32 PM, Dave Page wrote: > >> Hi >> >> On Thu, Aug 24, 2017 at 11:51 AM, H

Re: [pgAdmin4][RM2586] Cleanup feature test

2017-08-28 Thread Harshal Dhumal
Hi, Please find attached updated patch On Fri, Aug 25, 2017 at 2:32 PM, Dave Page wrote: > Hi > > On Thu, Aug 24, 2017 at 11:51 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> Last week Sarah, Matt and I had call regarding some issues with feature >> test cases. >>

Re: [pgAdmin4][RM2586] Cleanup feature test

2017-08-25 Thread Dave Page
Hi On Thu, Aug 24, 2017 at 11:51 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Last week Sarah, Matt and I had call regarding some issues with feature > test cases. > For example in auto commit disable test scenario from query tool test > cases by removing code line > *se

Re: [pgAdmin4][RM2586] Cleanup feature test

2017-08-24 Thread Harshal Dhumal
Hi, Last week Sarah, Matt and I had call regarding some issues with feature test cases. For example in auto commit disable test scenario from query tool test cases by removing code line *self.page.find_by_id("btn-auto-commit").click() *the test case scenario was not falling. This issue was due to

Re: [pgAdmin4][RM2586] Cleanup feature test

2017-08-10 Thread Sarah McAlear
Great job on cleaning up the whole feature test suite! This is really going to benefit all of the developers a lot. Thanks, Matt & Sarah On Fri, Aug 11, 2017 at 12:24 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached updated patch. In this patch I have r

Re: [pgAdmin4][RM2586] Cleanup feature test

2017-08-10 Thread Harshal Dhumal
Hi, Please find attached updated patch. In this patch I have removed unused imports. Regarding ajax calls on slow network/computer I have already taken care of those. Before sending first version of patch I tested this on Murtuza's machine and also tested on slow machine as well. Thanks, Harshal

Re: [pgAdmin4][RM2586] Cleanup feature test

2017-08-06 Thread Sarah McAlear
Hi Harshal! There are a few files in which there are leftover imports that are not needed anymore: - PGDataypeFeatureTest - PgadminPage - CheckForXssFeatureTest - CheckDebuggerForXssFeatureTest We also noticed that there were quite a few time.sleep functions that were removed. This

[pgAdmin4][RM2586] Cleanup feature test

2017-08-02 Thread Harshal Dhumal
Hi, Please find attached patch to improve feature test execution time. Now on my machine overall execution time is cut down to 280 seconds from 400+ seconds Changes: 1. Removed fixed python time.sleeps where ever possible. 2. Removed connect to server test cases. 3. Query tool test cases: i