Thanks - applied!
On Fri, May 25, 2018 at 6:52 AM, Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Anthony/Joao,
>
> That worked well !! Nice !! ( I am very new to Jasmine tests :P. Need to
> dig in. )
>
> Hackers,
> Kindly review the patch attached in the trailing mail for RM#3
Hi Anthony/Joao,
That worked well !! Nice !! ( I am very new to Jasmine tests :P. Need to
dig in. )
Hackers,
Kindly review the patch attached in the trailing mail for RM#3271
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Hea
Hello Aditya,
We changed the way the tests were running and we could remove the function.
Instead of piggybackiung on a deprecated field we created a html fixture
$('body').append(
'' +
'' +
'' +
''
);
With it we could use the real JQuery instead of mocking it.
Now the tests look like t
Hi,
No luck with data-test-selector. :(
I added data-test-selector to html tags. I get undefined for
.data('test-selector') as well as for .attr('data-test-selector').
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant
Hi Victoria/Joao,
Thank you for reviewing. The above function is probably the last solution
which I added.
The test cases in web/regression/javascript/sqleditor/execute_query_spec.js
calls the execute query function of pgAdmin4 sqleditor. The execution
disables/enables the buttons internally and i
HI Aditya,
Good job porting the app from the ancient version of JQuery to the latest
build :D
The patch in general looks good, and the patches-bot says all tests pass.
The only thing that we would like to point out is this piece of code:
/* jQuery has removed selector property in version 3.x
*
Hi Hackers,
Please find the updated patch for upgrading the jQuery version to 3.x. The
patch is only for pgAdmin4 code changes replacing old deprecated functions
with new replacement.
We need to look into external libraries used for any vulnerabilities.
Request you to kindly review.
Thanks and Re
Hi Hackers,
Please hold on with the patch. Will send the updated patch soon.
Apologies.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
On Mon, May 14, 2018 at 12:52 PM, Aditya Toshniwal <
aditya.toshni..
Hi Hackers,
PFA patch for upgrading jQuery version to 3.3.1 from current version
1.12.4. Patch includes replacing deprecated functions of jquery to latest
one.
Kindly review.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat
