Re: [pgAdmin4][RM#3195] Include service name when executing Backup, Restore etc tools

2018-03-19 Thread Dave Page
Thanks, applied. On Thu, Mar 15, 2018 at 4:15 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch which will allow tools to pickup Service name properly. > Please review. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Ent

Re: [pgAdmin4][RM#3195] Include service name when executing Backup, Restore etc tools

2018-03-15 Thread Murtuza Zabuawala
Thanks Joao and Victoria for reviewing. As Khushboo mentioned in her previous email we already have RM for the same( https://redmine.postgresql.org/issues/3206), We will send separate patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][RM#3195] Include service name when executing Backup, Restore etc tools

2018-03-15 Thread Victoria Henry
Hey Murtuza, This patch passed our test pipelines and it looks good. Do we have any tests around this behavior? Joao and Victoria

[pgAdmin4][RM#3195] Include service name when executing Backup, Restore etc tools

2018-03-15 Thread Murtuza Zabuawala
Hi, PFA patch which will allow tools to pickup Service name properly. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_3195.diff Description: Binary data