Re: [pgAdmin4][RM#3129] handle encoding issue in File manager

Thanks guys, patch applied. On Thu, Mar 1, 2018 at 10:11 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Joao, > The pipeline is green and I believe the change is good to be merged. > > Thanks > Joao > > On Thu, Mar 1, 2018 at 10:56 AM Murtuza Zabuawala enterprisedb.co

Re: [pgAdmin4][RM#3129] handle encoding issue in File manager

Hello Joao, The pipeline is green and I believe the change is good to be merged. Thanks Joao On Thu, Mar 1, 2018 at 10:56 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Thanks Joao for reviewing. > > Attaching updated patch fixing PEP8 issues. > > -- > Regards, > Murtuza Zab

Re: [pgAdmin4][RM#3129] handle encoding issue in File manager

Thanks Joao for reviewing. Attaching updated patch fixing PEP8 issues. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Mar 1, 2018 at 8:56 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Murtuza, > > T

Re: [pgAdmin4][RM#3129] handle encoding issue in File manager

Hello Murtuza, The code looks pretty good, love the fact that you extracted it so that our file size stop growing and get more manageable. All tests pass on our CI. The only issue I found was linting: pycodestyle --config=.pycodestyle pgadmin/tools/sqleditor/ pgadmin/tools/sqleditor/utils/query_

[pgAdmin4][RM#3129] handle encoding issue in File manager

Hi, PFA patch to fix the issue where user was not able to open the file with non utf-8 encoding. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/sqleditor/__init__.py b/web/pgadmin/tools/sqleditor/__init__.