Re: [pgAdmin4][RM#3072] Make pgagent job history rows configurable

Thanks, applied. On Fri, Apr 6, 2018 at 5:53 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Please find updated patch which fixes PEP8 issue, added help string for > preference dialog option & updated screenshot. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB:

Re: [pgAdmin4][RM#3072] Make pgagent job history rows configurable

Hi The description for the Preferences field doesn't seem to be there in the code or the screenshot. I suggested below using: "The maximum number of history rows to show on the Statistics tab for pgAgent jobs." Thanks. On Thu, Apr 5, 2018 at 1:09 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterpr

Re: [pgAdmin4][RM#3072] Make pgagent job history rows configurable

Sorry Murtuza - I'm mixing patches up here. It's the sort/filter one I need the image for please. Which means this patch needs re-creating as well please. On Thu, Apr 5, 2018 at 3:03 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find attached PNG. > > O

Re: [pgAdmin4][RM#3072] Make pgagent job history rows configurable

Murtuza, please send me the screenshot as a PNG. I've been tweaking the code and will recreate the patch with my changes. On Thu, Apr 5, 2018 at 2:53 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Murtuza, > Generally the patch looks good passes all CI but the linter fail

Re: [pgAdmin4][RM#3072] Make pgagent job history rows configurable

Hi Murtuza, Generally the patch looks good passes all CI but the linter fails: /tmp/build/4a5630c2/pivotal-rm-3072/web /tmp/build/4a5630c2 ./pgadmin/browse

Re: [pgAdmin4][RM#3072] Make pgagent job history rows configurable

On Thu, Apr 5, 2018 at 4:43 PM, Dave Page wrote: > Hi > > On Thu, Apr 5, 2018 at 11:10 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA patch which allow user to configure how many rows they wish to >> display for any pgagent jobs on statistics panel. >> > > I think this is esse

Re: [pgAdmin4][RM#3072] Make pgagent job history rows configurable

On Thu, Apr 5, 2018 at 4:43 PM, Dave Page wrote: > Hi > > On Thu, Apr 5, 2018 at 11:10 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA patch which allow user to configure how many rows they wish to >> display for any pgagent jobs on statistics panel. >> > > I think this is esse

Re: [pgAdmin4][RM#3072] Make pgagent job history rows configurable

Hi On Thu, Apr 5, 2018 at 11:10 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch which allow user to configure how many rows they wish to display > for any pgagent jobs on statistics panel. > I think this is essentially good, however, I'm really not happy wi