Can you rebase this please?
On Wed, Mar 28, 2018 at 8:19 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi Dave,
>
> Please find updated patch with following changes,
> - Combined Filter and Data sorting together same as pgAdmin3.
> - Extracted model into separate file
> - C
On Wed, Mar 28, 2018 at 4:28 PM, Robert Eckhardt
wrote:
>
>
> On Wed, Mar 28, 2018 at 11:20 AM, Dave Page wrote:
>
>>
>>
>> On Wed, Mar 28, 2018 at 2:54 PM, Robert Eckhardt
>> wrote:
>>
>>>
>>>
>>> On Wed, Mar 28, 2018 at 4:12 AM, Dave Page wrote:
>>>
On Wed, Mar 28, 2018 at 1:3
On Wed, Mar 28, 2018 at 11:20 AM, Dave Page wrote:
>
>
> On Wed, Mar 28, 2018 at 2:54 PM, Robert Eckhardt
> wrote:
>
>>
>>
>> On Wed, Mar 28, 2018 at 4:12 AM, Dave Page wrote:
>>
>>>
>>>
>>> On Wed, Mar 28, 2018 at 1:37 AM, Robert Eckhardt
>>> wrote:
>>>
On Tue, Mar 27, 2018 at
On Wed, Mar 28, 2018 at 2:54 PM, Robert Eckhardt
wrote:
>
>
> On Wed, Mar 28, 2018 at 4:12 AM, Dave Page wrote:
>
>>
>>
>> On Wed, Mar 28, 2018 at 1:37 AM, Robert Eckhardt
>> wrote:
>>
>>>
>>>
>>> On Tue, Mar 27, 2018 at 9:54 AM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote
On Wed, Mar 28, 2018 at 4:12 AM, Dave Page wrote:
>
>
> On Wed, Mar 28, 2018 at 1:37 AM, Robert Eckhardt
> wrote:
>
>>
>>
>> On Tue, Mar 27, 2018 at 9:54 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Tue, Mar 27, 2018 at 7:06 PM, Robert Eckhardt
>>> wro
On Wed, Mar 28, 2018 at 1:37 AM, Robert Eckhardt
wrote:
>
>
> On Tue, Mar 27, 2018 at 9:54 AM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>>
>>
>> On Tue, Mar 27, 2018 at 7:06 PM, Robert Eckhardt
>> wrote:
>>
>>>
>>>
>>> On Tue, Mar 27, 2018 at 6:25 AM, Murtuza Zabuawala
On Tue, Mar 27, 2018 at 9:54 AM, Murtuza Zabuawala wrote:
>
>
> On Tue, Mar 27, 2018 at 7:06 PM, Robert Eckhardt
> wrote:
>
>>
>>
>> On Tue, Mar 27, 2018 at 6:25 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> On Tue, Mar 27, 2018 at 3:13 PM, Dave Page wrote:
>>>
>>
On Tue, Mar 27, 2018 at 7:06 PM, Robert Eckhardt
wrote:
>
>
> On Tue, Mar 27, 2018 at 6:25 AM, Murtuza Zabuawala enterprisedb.com> wrote:
>
>> On Tue, Mar 27, 2018 at 3:13 PM, Dave Page wrote:
>>
>>>
>>>
>>> On Mon, Mar 26, 2018 at 9:26 PM, Robert Eckhardt
>>> wrote:
>>>
On Mon,
On Tue, Mar 27, 2018 at 6:25 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> On Tue, Mar 27, 2018 at 3:13 PM, Dave Page wrote:
>
>>
>>
>> On Mon, Mar 26, 2018 at 9:26 PM, Robert Eckhardt
>> wrote:
>>
>>>
>>>
>>> On Mon, Mar 26, 2018 at 2:07 PM, Joao De Almeida Pereira <
>>>
On Tue, Mar 27, 2018 at 3:13 PM, Dave Page wrote:
>
>
> On Mon, Mar 26, 2018 at 9:26 PM, Robert Eckhardt
> wrote:
>
>>
>>
>> On Mon, Mar 26, 2018 at 2:07 PM, Joao De Almeida Pereira <
>> jdealmeidapere...@pivotal.io> wrote:
>>
>>> Hi Hackers,
>>>
>>> @Murtuza: The patch codewise looks good. Nice
On Mon, Mar 26, 2018 at 9:26 PM, Robert Eckhardt
wrote:
>
>
> On Mon, Mar 26, 2018 at 2:07 PM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hi Hackers,
>>
>> @Murtuza: The patch codewise looks good. Nice to see that we are using
>> axios instead of jquery ajax calls and t
On Mon, Mar 26, 2018 at 2:07 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hi Hackers,
>
> @Murtuza: The patch codewise looks good. Nice to see that we are using
> axios instead of jquery ajax calls and that there is some coverage for the
> change.
> Nevertheless the Javascr
Hi Hackers,
@Murtuza: The patch codewise looks good. Nice to see that we are using
axios instead of jquery ajax calls and that there is some coverage for the
change.
Nevertheless the Javascript testing looks a bit slim and could be improved.
Also the DataSorting class could have some other member
On Mon, Mar 26, 2018 at 5:52 PM, Dave Page wrote:
> Hi
>
> On Sun, Mar 25, 2018 at 7:13 PM, Murtuza Zabuawala enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA patch which allow user to sort the data in View data mode.
>>
>
> The patch looks good in general, however I'm not sure about the UI, in
> par
Hi
On Sun, Mar 25, 2018 at 7:13 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi,
>
> PFA patch which allow user to sort the data in View data mode.
>
The patch looks good in general, however I'm not sure about the UI, in
particular that the closely-linked dialogue for fil
Hi,
PFA patch which allow user to sort the data in View data mode.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
RM_3055.diff
Description: Binary data
16 matches
Mail list logo
