Thanks guys - patch applied.
On Mon, Feb 26, 2018 at 5:31 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Thank you Joao for reviewing.
>
> On Mon, Feb 26, 2018 at 10:43 PM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hello Murtuza,
>> We just passed
Thank you Joao for reviewing.
On Mon, Feb 26, 2018 at 10:43 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hello Murtuza,
> We just passed the patch through our CI pipeline and all tests pass. The
> patch looks good.
>
> Sorry that the patch I sent didn't help. Nevertheless
Hello Murtuza,
We just passed the patch through our CI pipeline and all tests pass. The
patch looks good.
Sorry that the patch I sent didn't help. Nevertheless when I finish the
tasks that we want to try to get accepted for pgAdmin4 3.0 release I will
try to change the way the preferences are retr
Hi Joao,
I tried the solution/patch you suggested but it is not working for me, I
always get *undefined* for preferences values.
Thanks,
Murtuza
On Thu, Feb 22, 2018 at 3:17 AM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hello Murtuza,
> I created a small patch on the way
FYI, in an attempt not to be the one reviewing everything, I'm leaving this
for Joao to pick up again. Moving forwards, I'd like to make that the
default - if (better yet, when) someone reviews someone else's patch, we
should expect that person to review any followups as well, unless they
explicitl
Hello Murtuza,
I created a small patch on the way I believe the function should work. Not
100% sure why we are piggybacking on the window.top, window.opener and so
on to give us information. Nowadays I do not think that loading the JS
files again costs that much in terms of time.
The issue I came
Hi Joao,
Thank you for your time in reviewing the patch.
On Wed, Feb 21, 2018 at 9:11 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hello Murtuza,
> After reviewing the code I have some suggestions:
> - We should split the PEP and the features into different patches, or
Hello Murtuza,
After reviewing the code I have some suggestions:
- We should split the PEP and the features into different patches, or else
it becomes very hard to separate Feature code from Code Style change
- The function: `getTextRepresentaionShortcut` has a typo
- As a personal point I have
