Re: [pgAdmin4][Patch] Remake Docker container packaging

> On 4 Apr 2018, at 19:28, Максим Кольцов wrote: > > 2018-04-04 18:22 GMT+03:00 Dave Page : >> Hi >> >>> On Wed, Apr 4, 2018 at 2:46 PM, Максим Кольцов wrote: >>> >>> >>> So, I've fixed it. Patch attached. Now whole requirements.txt is >>> installed in one step, with no left-overs and incom

Re: [pgAdmin4][Patch] Remake Docker container packaging

2018-04-04 18:22 GMT+03:00 Dave Page : > Hi > > On Wed, Apr 4, 2018 at 2:46 PM, Максим Кольцов wrote: >> >> >> So, I've fixed it. Patch attached. Now whole requirements.txt is >> installed in one step, with no left-overs and incompabilities. > > > I've committed the patch with some minor changes t

Re: [pgAdmin4][Patch] Remake Docker container packaging

Hi On Wed, Apr 4, 2018 at 2:46 PM, Максим Кольцов wrote: > > So, I've fixed it. Patch attached. Now whole requirements.txt is > installed in one step, with no left-overs and incompabilities. I've committed the patch with some minor changes to avoid breaking compatibility with the older version

Re: [pgAdmin4][Patch] Remake Docker container packaging

2018-04-04 14:18 GMT+03:00 Dave Page : > > > On Wed, Apr 4, 2018 at 12:16 PM, Максим Кольцов wrote: >> >> 2018-04-04 13:55 GMT+03:00 Dave Page : >> > Hi >> > >> > On Wed, Apr 4, 2018 at 9:46 AM, Максим Кольцов >> > wrote: >> >> >> >> I've updated patch. Now I drop tests and regressions. >> >> >>

Re: [pgAdmin4][Patch] Remake Docker container packaging

2018-04-04 14:16 GMT+03:00 Максим Кольцов : > 2018-04-04 13:55 GMT+03:00 Dave Page : >> Hi >> >> On Wed, Apr 4, 2018 at 9:46 AM, Максим Кольцов wrote: >>> >>> I've updated patch. Now I drop tests and regressions. >>> >>> And I added new env var: PGADMIN_LISTEN_PORT. Default value is 8080 for >>> h

Re: [pgAdmin4][Patch] Remake Docker container packaging

On Wed, Apr 4, 2018 at 12:16 PM, Максим Кольцов wrote: > 2018-04-04 13:55 GMT+03:00 Dave Page : > > Hi > > > > On Wed, Apr 4, 2018 at 9:46 AM, Максим Кольцов > wrote: > >> > >> I've updated patch. Now I drop tests and regressions. > >> > >> And I added new env var: PGADMIN_LISTEN_PORT. Default v

Re: [pgAdmin4][Patch] Remake Docker container packaging

2018-04-04 13:55 GMT+03:00 Dave Page : > Hi > > On Wed, Apr 4, 2018 at 9:46 AM, Максим Кольцов wrote: >> >> I've updated patch. Now I drop tests and regressions. >> >> And I added new env var: PGADMIN_LISTEN_PORT. Default value is 8080 for >> http and 8443 for https mode. >> >> Please review. > >

Re: [pgAdmin4][Patch] Remake Docker container packaging

Hi On Wed, Apr 4, 2018 at 9:46 AM, Максим Кольцов wrote: > I've updated patch. Now I drop tests and regressions. > > And I added new env var: PGADMIN_LISTEN_PORT. Default value is 8080 for > http and 8443 for https mode. > > Please review. > I'm seeing the following error when building. It look

Re: [pgAdmin4][Patch] Remake Docker container packaging

пн, 2 апр. 2018 г., 7:54 Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com>: > Hello, > > I tested the patch and it is working fine. > > - I had clean system before but after running DockerBuild, I can see 3 > different images of pgAdmin4, Is this expected? > Yes, this is expected and is the

Re: [pgAdmin4][Patch] Remake Docker container packaging

Hello, I tested the patch and it is working fine. - I had clean system before but after running DockerBuild, I can see 3 different images of pgAdmin4, Is this expected? - We can remove /tests/ folder from each folders, we can also remove /web/regression/ folder from the container, they are used

[pgAdmin4][Patch] Remake Docker container packaging

Hi all, I've been discussing this with Dave for about a month now. Today I finally present a proposed patch to update pgadmin4's Docker packaging. Key features of this update: - Main image is based on python:3.6-alpine3.7. Using Alpine linux leads to much smaller image - All build is done with