Re: [pgAdmin4][Patch] - RM 5422 - Synonym Dependencies tab shows incorrect data

2020-05-04 Thread Akshay Joshi
Thanks, patch applied. On Wed, Apr 29, 2020 at 1:29 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Navnath, > > On Wed, Apr 29, 2020 at 12:16 PM navnath gadakh < > navnath.gad...@enterprisedb.com> wrote: > >> Hi Khushboo, >> >> Patch looks good to me except there are no API tes

Re: [pgAdmin4][Patch] - RM 5422 - Synonym Dependencies tab shows incorrect data

2020-04-29 Thread Khushboo Vashi
Hi Navnath, On Wed, Apr 29, 2020 at 12:16 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Khushboo, > > Patch looks good to me except there are no API test cases written for > dependents and dependencies. > > Thanks for the review. We don't have API test cases for dependents and

Re: [pgAdmin4][Patch] - RM 5422 - Synonym Dependencies tab shows incorrect data

2020-04-28 Thread navnath gadakh
Hi Khushboo, Patch looks good to me except there are no API test cases written for dependents and dependencies. Thanks! On Wed, Apr 29, 2020 at 10:40 AM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi , > > I'm reviewing this task. > > On Wed, Apr 29, 2020 at 9:36 AM Khushboo Va

Re: [pgAdmin4][Patch] - RM 5422 - Synonym Dependencies tab shows incorrect data

2020-04-28 Thread navnath gadakh
Hi , I'm reviewing this task. On Wed, Apr 29, 2020 at 9:36 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM 5422 - Synonym Dependencies > tab shows incorrect data. > > Thanks, > Khushboo > -- Regards, Navnath Gadakh

[pgAdmin4][Patch] - RM 5422 - Synonym Dependencies tab shows incorrect data

2020-04-28 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM 5422 - Synonym Dependencies tab shows incorrect data. Thanks, Khushboo RM_5422.patch Description: Binary data