Re: [pgAdmin4][Patch] - RM 4555 - RE-SQL for Exclusion Constraint

2019-08-05 Thread Akshay Joshi
Thanks patch applied. On Mon, Aug 5, 2019 at 2:00 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached updated patch. > > On Mon, Aug 5, 2019 at 1:20 PM Akshay Joshi > wrote: > >> Hi Khushboo >> >> Test case are working fine, some minor review com

Re: [pgAdmin4][Patch] - RM 4555 - RE-SQL for Exclusion Constraint

2019-08-05 Thread Khushboo Vashi
Hi Akshay, Please find the attached updated patch. On Mon, Aug 5, 2019 at 1:20 PM Akshay Joshi wrote: > Hi Khushboo > > Test case are working fine, some minor review comments: > >- Scenario name "Create/Alter Exclusion Constraint" repeating twice >instead of that it should be more under

Re: [pgAdmin4][Patch] - RM 4555 - RE-SQL for Exclusion Constraint

2019-08-05 Thread Akshay Joshi
Hi Khushboo Test case are working fine, some minor review comments: - Scenario name "Create/Alter Exclusion Constraint" repeating twice instead of that it should be more understandable. - File name should not be like "create/alter_exclusion_constraint_1.sql" it should be like 'alter_c

[pgAdmin4][Patch] - RM 4555 - RE-SQL for Exclusion Constraint

2019-08-05 Thread Khushboo Vashi
Hi, Please find the attached patch for the RE-SQL tests of the Exclusion constraint node with some bug fixes in SQL. Thanks, Khushboo RM_4555.patch Description: Binary data