Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Thanks, patch applied. On Fri, Apr 3, 2020 at 2:37 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > On Fri, Apr 3, 2020 at 1:50 PM Akshay Joshi > wrote: > >> Hi Khushboo >> >> Some more review comments: >> >>- Fix one small PEP

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Hi, Please find the attached updated patch. On Fri, Apr 3, 2020 at 1:50 PM Akshay Joshi wrote: > Hi Khushboo > > Some more review comments: > >- Fix one small PEP8 issue. > > Fixed. > >- If ipAddress or Port is not set in the configuration file then >browser showing the following d

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Hi Khushboo Some more review comments: - Fix one small PEP8 issue. - If ipAddress or Port is not set in the configuration file then browser showing the following data, it should be shown proper error message on the login page - {"success":0,"errormsg":"Port could not be cast to

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Hi Akshay, Please find the attached updated patch. On Thu, Apr 2, 2020 at 4:55 PM Akshay Joshi wrote: > Hi Khushboo > > Following are the initial review comments (GUI): > > *Desktop Mode: * > >- KeyError: '_auth_source_manager_obj' in desktop mode. (*Note* error >occurs when the patch h

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Hi Khushboo Following are the initial review comments (GUI): *Desktop Mode: * - KeyError: '_auth_source_manager_obj' in desktop mode. (*Note* error occurs when the patch has applied and server mode is False.) *Server Mode:* AUTHENTICATION_SOURCES = ['internal'] - Try to add a new us

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Hi, Resending the patch. Missed the requirements.txt file in the previous patch. Thanks, Khushboo On Wed, Apr 1, 2020 at 5:38 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch which includes the review comments > given in the review mee

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Hi, Please find the attached updated patch which includes the review comments given in the review meeting: 1. Do not store password for ldap user in sqlite database 2. Forgot Password : Give error to ldap users 3. User Management dialog changes 4. Authentication source display besides username /

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Please disregard my previous patch, attached the updated patch. :) On Tue, Mar 24, 2020 at 10:32 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Please disregard my previous patch, attached the updated patch. > > On Tue, Mar 24, 2020 at 10:29 AM Khushboo Vashi < > khushboo.va...@en

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Please disregard my previous patch, attached the updated patch. On Tue, Mar 24, 2020 at 10:29 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > > On Tue, Mar 17, 2020 at 4:11 PM Dave Page wrote: > >> Hi >> >> On Tue, Mar 17, 2020 at

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Hi, Please find the attached updated patch. On Tue, Mar 17, 2020 at 4:11 PM Dave Page wrote: > Hi > > On Tue, Mar 17, 2020 at 10:24 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Thanks for the review. >> >> On Tue, Mar 17, 2020 at 3:42 PM Dave Page wrote: >

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Hi On Tue, Mar 17, 2020 at 10:24 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > Thanks for the review. > > On Tue, Mar 17, 2020 at 3:42 PM Dave Page wrote: > >> Hi >> >> 30 second read of the first version of the patch... >> >> - Please move the configuration into con

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Hi Navnath, On Tue, Mar 17, 2020 at 3:37 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Khushboo, >I think there is no use of > > +if app is not None: > +AuthSourceRegistry.load_auth_sources() > + > > in get_auth_sources() function. > > Thanks for the review,

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Hi Dave, Thanks for the review. On Tue, Mar 17, 2020 at 3:42 PM Dave Page wrote: > Hi > > 30 second read of the first version of the patch... > > - Please move the configuration into config.py. Users should never have to > modify a distributed file (it messes up packaging). I don't see any reas

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Hi 30 second read of the first version of the patch... - Please move the configuration into config.py. Users should never have to modify a distributed file (it messes up packaging). I don't see any reason to use a different file just for auth config. - I think all config options should be prefix

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Hi Khushboo, I think there is no use of +if app is not None: +AuthSourceRegistry.load_auth_sources() + in get_auth_sources() function. On Tue, Mar 17, 2020 at 2:25 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to support

[pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Hi, Please find the attached patch to support LDAP Authentication in Server mode. To test the patch, config_auth.py needs to be configured for LDAP configurations. The config settings are explained in this file in detail. After configuring the parameters, start the pgadmin server in Server mode an