Re: [pgAdmin4][Patch] - RM 1402 - Macro support like pgAdmin3

2020-09-28 Thread Akshay Joshi
Thanks, patch applied. On Mon, Sep 28, 2020 at 2:18 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Wed, Sep 23, 2020 at 5:42 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >

Re: [pgAdmin4][Patch] - RM 1402 - Macro support like pgAdmin3

2020-09-23 Thread Akshay Joshi
Hi Khushboo Following are the GUI review comments: - If we provide anyone value either Name or SQL it throws Alertify error message with 'name' or 'SQL'. The error message should be correct. [image: Name_Error.png] - We should not enable the 'Save' button if the value of Nam

[pgAdmin4][Patch] - RM 1402 - Macro support like pgAdmin3

2020-09-21 Thread Khushboo Vashi
Hi, Please find the attached patch for RM 1402 - Macro support like pgAdmin3. Thanks, Khushboo RM_1402.patch Description: Binary data