Re: [pgAdmin4][Patch] - RM #6129 - Port browser tree to React

2021-09-27 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Sep 27, 2021 at 1:51 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > All the review comments are fixed, please find the attached updated patch. > > Thanks, > Khushboo > > On Fri, Sep 24, 2021 at 4:25 PM Akshay Joshi < > akshay.jo...@

Re: [pgAdmin4][Patch] - RM #6129 - Port browser tree to React

2021-09-24 Thread Akshay Joshi
Hi Khushboo Following are the review comments with the new patch: - Select any collection node and make sure that the collection node should not have a single child. For example Cast, FDW, etc... Create a new Cast/FDW node it will not immediately be visible under the collection node.

Re: [pgAdmin4][Patch] - RM #6129 - Port browser tree to React

2021-09-17 Thread Akshay Joshi
Hi Khushboo Following are the GUI review comments: - Arrow ( > ) is not center-aligned with the node labels. - Sorting of tree items is not correct when you have servers like (PostgreSQL 9.5, PostgreSQL 9.6, PostgreSQL 10...) - Servers collection node not showing count while expanding