Re: [pgAdmin4][Patch] - Improve LDAP Error messages

2020-04-27 Thread Akshay Joshi
Thanks, patch applied. On Mon, Apr 27, 2020 at 3:07 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached updated patch. > This patch also fixes the RM #5439 - User can not create server if login > done with LDAP. > > Thanks, > Khushboo > > > On Mon

Re: [pgAdmin4][Patch] - Improve LDAP Error messages

2020-04-27 Thread Khushboo Vashi
Hi Akshay, Please find the attached updated patch. This patch also fixes the RM #5439 - User can not create server if login done with LDAP. Thanks, Khushboo On Mon, Apr 27, 2020 at 1:46 PM Akshay Joshi wrote: > Hi Khushboo > > We should use the format() method instead of %. As it may create p

Re: [pgAdmin4][Patch] - Improve LDAP Error messages

2020-04-27 Thread Akshay Joshi
Hi Khushboo We should use the format() method instead of %. As it may create problems in translation. Please fix and resend the patch. On Mon, Apr 27, 2020 at 9:30 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to improve the ldap error messa

[pgAdmin4][Patch] - Improve LDAP Error messages

2020-04-26 Thread Khushboo Vashi
Hi, Please find the attached patch to improve the ldap error messages. Thanks, Khushboo ldap_error_messages.patch Description: Binary data