Hi
Awesome - that works nicely. Patch committed.
Congratulations on your first feature!
Regards, Dave.
On Mon, Jun 26, 2017 at 8:56 AM, Atul Sharma
wrote:
> Hi Dave,
>
> Yes, It makes sense to use the same approach at both ends. I have modified
> the server file to use the same regex approach.
Hi Dave,
Yes, It makes sense to use the same approach at both ends. I have modified
the server file to use the same regex approach.
Attached is the patch for the same. Please review.
Regards,
Atul
On Sun, Jun 25, 2017 at 6:32 PM, Dave Page wrote:
> Hi
>
> There are still validation issues unfo
Hi Dave,
Please find updated version attached.
Regards,
Atul
On Fri, Jun 23, 2017 at 8:49 PM, Dave Page wrote:
> Hi,
>
> I'm getting:
>
> (pgadmin4)piranha:pgadmin4 dpage$ git apply ~/Downloads/RM_2191_ver2.patch
> error: cannot apply binary patch to
> 'docs/en_US/images/server_advanced.png' w
Hi,
I'm getting:
(pgadmin4)piranha:pgadmin4 dpage$ git apply ~/Downloads/RM_2191_ver2.patch
error: cannot apply binary patch to
'docs/en_US/images/server_advanced.png' without full index line
error: docs/en_US/images/server_advanced.png: patch does not apply
when trying to apply. If memory serve
Hi,
Please find updated patch.
Regards,
Atul
On Thu, Jun 22, 2017 at 5:02 PM, Dave Page wrote:
> Hi
>
> On Thu, Jun 22, 2017 at 11:05 AM, Atul Sharma
> wrote:
> > Hi,
> >
> > Please find attached patch for RM #2191 : Add support for hostaddr
> > connection parameter
>
> Unfortunately there ar
Hi
On Thu, Jun 22, 2017 at 11:05 AM, Atul Sharma
wrote:
> Hi,
>
> Please find attached patch for RM #2191 : Add support for hostaddr
> connection parameter
Unfortunately there are a few issues with this patch:
- It needs rebasing (blame Ashesh :-p )
- It's missing the documentation update (and
Hi,
Please find attached patch for RM #2191 : Add support for hostaddr
connection parameter
Thanks,
Atul
RM_2191.patch
Description: Binary data
