Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

2017-11-22 Thread Dave Page
On Wed, Nov 22, 2017 at 5:46 AM, Ashesh Vashi wrote: > On Wed, Nov 22, 2017 at 11:00 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> ​Hi Dave, >> >> On Tue, Nov 21, 2017 at 10:53 PM, Dave Page wrote: >> >>> Hi >>> >>> On Tue, Nov 21, 2017 at 1:17 PM, Murtuza Zabuawala < >>> murtuza.zabuaw..

Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

2017-11-22 Thread Dave Page
Thanks, both applied! On Wed, Nov 22, 2017 at 5:30 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > ​Hi Dave, > > On Tue, Nov 21, 2017 at 10:53 PM, Dave Page wrote: > >> Hi >> >> On Tue, Nov 21, 2017 at 1:17 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote

Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

2017-11-21 Thread Ashesh Vashi
On Wed, Nov 22, 2017 at 11:00 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > ​Hi Dave, > > On Tue, Nov 21, 2017 at 10:53 PM, Dave Page wrote: > >> Hi >> >> On Tue, Nov 21, 2017 at 1:17 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi Dave, >>>

Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

2017-11-21 Thread Murtuza Zabuawala
​Hi Dave, On Tue, Nov 21, 2017 at 10:53 PM, Dave Page wrote: > Hi > > On Tue, Nov 21, 2017 at 1:17 PM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi Dave, >> >> PFA updated patch. >> >> On Tue, Nov 21, 2017 at 4:16 PM, Dave Page wrote: >> >>> HI >>> >>> On Tue, Nov 21

Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

2017-11-21 Thread Dave Page
Hi On Tue, Nov 21, 2017 at 1:17 PM, Murtuza Zabuawala wrote: > Hi Dave, > > PFA updated patch. > > On Tue, Nov 21, 2017 at 4:16 PM, Dave Page wrote: > >> HI >> >> On Tue, Nov 21, 2017 at 6:16 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> PFA updat

Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

2017-11-21 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch. On Tue, Nov 21, 2017 at 4:16 PM, Dave Page wrote: > HI > > On Tue, Nov 21, 2017 at 6:16 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> PFA updated patch with custom tristate boolean editor for SlickGrid to >> make it compatible with Qt runtime. >

Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

2017-11-21 Thread Dave Page
HI On Tue, Nov 21, 2017 at 6:16 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch with custom tristate boolean editor for SlickGrid to > make it compatible with Qt runtime. > I have tested it web mode & also modified the feature test accordingly.

Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

2017-11-16 Thread Dave Page
On Thu, Nov 16, 2017 at 4:30 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > On Thu, Nov 16, 2017 at 8:59 PM, Dave Page wrote: > >> Hi >> >> On Thu, Nov 16, 2017 at 2:04 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA

Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

2017-11-16 Thread Murtuza Zabuawala
Hi Dave, On Thu, Nov 16, 2017 at 8:59 PM, Dave Page wrote: > Hi > > On Thu, Nov 16, 2017 at 2:04 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to fix the issue in boolean editor & also corrected feature >> test. >> RM#2848 >> > > Testing in webkit on Mac (Qt 5.8), the

Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

2017-11-16 Thread Dave Page
Hi On Thu, Nov 16, 2017 at 2:04 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue in boolean editor & also corrected feature test. > RM#2848 > Testing in webkit on Mac (Qt 5.8), the problem does not appear to be solved for me. I have run make

[pgAdmin4][Patch]: To fix issues in Boolean editor

2017-11-16 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in boolean editor & also corrected feature test. RM#2848 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/feature_tests/view_data_dml_queries.py b/web/pgadmin/feature_tests/view_data_