Re: [pgAdmin4][Patch]: To fix Indentation issue in query tool

2017-10-16 Thread Dave Page
Thanks - applied with a minor tweak to the help message. On Mon, Oct 16, 2017 at 1:56 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find updated patch. > > On Mon, Oct 16, 2017 at 5:56 PM, Dave Page wrote: > >> Hi >> >> On Mon, Oct 16, 2017 at 1:21 PM,

Re: [pgAdmin4][Patch]: To fix Indentation issue in query tool

2017-10-16 Thread Murtuza Zabuawala
Hi Dave, Please find updated patch. On Mon, Oct 16, 2017 at 5:56 PM, Dave Page wrote: > Hi > > On Mon, Oct 16, 2017 at 1:21 PM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Sorry, that was a typo in 'sqleditor/__init__.py'. >> >> I have updated the patch, We require thi

Re: [pgAdmin4][Patch]: To fix Indentation issue in query tool

2017-10-16 Thread Dave Page
Hi On Mon, Oct 16, 2017 at 1:21 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Sorry, that was a typo in 'sqleditor/__init__.py'. > > I have updated the patch, We require this option because by default > codemirror indent the code with spaces. > > Steps to re-produce (withou

Re: [pgAdmin4][Patch]: To fix Indentation issue in query tool

2017-10-16 Thread Murtuza Zabuawala
Sorry, that was a typo in 'sqleditor/__init__.py'. I have updated the patch, We require this option because by default codemirror indent the code with spaces. Steps to re-produce (without patch): 1) With preference option Use spaces? = False Tab size = 4 2) Open query tool - Press Tabs key 3

Re: [pgAdmin4][Patch]: To fix Indentation issue in query tool

2017-10-16 Thread Dave Page
Hi On Mon, Oct 16, 2017 at 5:43 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where indentation is not working as expected, > when user opt for tab based indentation instead of space based indentation. > RM#2780 > Shouldn't we just use th

[pgAdmin4][Patch]: To fix Indentation issue in query tool

2017-10-15 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where indentation is not working as expected, when user opt for tab based indentation instead of space based indentation. RM#2780 Patch also includes some misc PEP-8 related changes. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterp