Re: [pgAdmin4][Patch]: Stop Flask from initialising service twice in Debug mode

2017-07-21 Thread Matthew Kleiman
Surinder, you are my hero! 🎁 On Fri, Jul 21, 2017 at 4:47 AM, Dave Page wrote: > Thanks, applied. The reloader has always been a little temperamental for > me, so I couldn't prove this doesn't break it. If someone finds it does, > please yelp. > > On Fri, Jul 21, 2017 at 8:27 AM, Surinder Kumar

Re: [pgAdmin4][Patch]: Stop Flask from initialising service twice in Debug mode

2017-07-21 Thread Dave Page
Thanks, applied. The reloader has always been a little temperamental for me, so I couldn't prove this doesn't break it. If someone finds it does, please yelp. On Fri, Jul 21, 2017 at 8:27 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > In this patch, i have added reference t

Re: [pgAdmin4][Patch]: Stop Flask from initialising service twice in Debug mode

2017-07-21 Thread Surinder Kumar
Hi In this patch, i have added reference to the implementation. Please find updated patch and review. Thanks, Surinder On Fri, Jul 21, 2017 at 12:32 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > When pgAdmin4 runs in DEBUG mode, Flask initialise service twice, while in >

[pgAdmin4][Patch]: Stop Flask from initialising service twice in Debug mode

2017-07-21 Thread Surinder Kumar
Hi When pgAdmin4 runs in DEBUG mode, Flask initialise service twice, while in non-DEBUG mode, once. It is pain while development because `yarn run bundle` also runs twice. It is because the parameter `use_reloader` = True in Debug Mode. If `os.environ` variable `WERKZEUG_RUN_MAIN` is set to None