Working on it.
-- Rob
On Thu, Jul 6, 2017 at 10:03 AM, Dave Page wrote:
> And, Houston, we have a problem. The layout is quite broken on IE - which
> of course we're working to use on Windows. Can you take a look ASAP please
> Matt & friends?
>
> Screenshot attached.
>
> On Thu, Jul 6, 2017 at
And, Houston, we have a problem. The layout is quite broken on IE - which
of course we're working to use on Windows. Can you take a look ASAP please
Matt & friends?
Screenshot attached.
On Thu, Jul 6, 2017 at 1:08 PM, Dave Page wrote:
> Thanks, applied.
>
> On Wed, Jul 5, 2017 at 4:31 PM, Matth
Thanks, applied.
On Wed, Jul 5, 2017 at 4:31 PM, Matthew Kleiman wrote:
> Sorry Dave. It looks like we had formatted the patch incorrectly. We have
> recreated the patch.
>
> Matt and Sarah
>
> On Wed, Jul 5, 2017 at 10:49 AM, Dave Page wrote:
>
>> Hi
>>
>> On Wed, Jul 5, 2017 at 2:54 PM, Matth
Sorry Dave. It looks like we had formatted the patch incorrectly. We have
recreated the patch.
Matt and Sarah
On Wed, Jul 5, 2017 at 10:49 AM, Dave Page wrote:
> Hi
>
> On Wed, Jul 5, 2017 at 2:54 PM, Matthew Kleiman
> wrote:
>
>> 1) I see the font used for class .query-history .entry is mono
Hi
On Wed, Jul 5, 2017 at 2:54 PM, Matthew Kleiman wrote:
> 1) I see the font used for class .query-history .entry is monospace,
>> shouldn't it be Helvetica as per style guide ? the font for Messages > text
>> is also monospace.
>>
>
> As per Dave's comment, we have added this to the styleguid
>
> 1) I see the font used for class .query-history .entry is monospace,
> shouldn't it be Helvetica as per style guide ? the font for Messages > text
> is also monospace.
>
As per Dave's comment, we have added this to the styleguide backlog. We
will be adding monospace entries to the styleguide
Hi
> 2) Can 1px top border be added above first entry in left panel to
> differentiate from above panels ?
>
> It sounds like you're describing the distinction between the query history
entries and the Messages, History, etc. tab bar (screenshot attached).
If so, the gray/blue contrast should be s
> On 30 Jun 2017, at 18:00, Surinder Kumar
> wrote:
>
> Hi,
>
> Review comments:
>
> 1) I see the font used for class .query-history .entry is monospace,
> shouldn't it be Helvetica as per style guide ? the font for Messages > text
> is also monospace.
No, the style guide needs an entry
Hi,
On Fri, Jun 30, 2017 at 10:30 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Hi,
>
> Review comments:
>
> 1) I see the font used for class .query-history .entry is monospace,
> shouldn't it be Helvetica as per style guide ? the font for Messages > text
> is also monospace.
>
Surinder,
It would be great if you could take a look at this an see if the style
changes are more inline with what you were thinking when you commented on
the first patch.
-- Rob
On Fri, Jun 30, 2017 at 11:55 AM, Shruti Iyer wrote:
> Hi Hackers,
>
> Attached is the patch that refactors the rea
Hi Hackers,
Attached is the patch that refactors the react components that supports the
history detail pane. We moved inline styling. whenever possible, to scss.
Thanks,
Joao and Shruti
refactor-react-history.diff
Description: Binary data
11 matches
Mail list logo
