Re: [pgAdmin4][Patch] RM #3277 Runtime startup error handling is broken on Windows

Thanks, applied. On Thu, May 31, 2018 at 4:52 AM, Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch file to fix RM #3277 Runtime startup error handling > is broken on Windows. I have figure out the crash at the following call of > Server.cpp(line no 326): > > PyRun_SimpleFile(fdopen(Py

Re: [pgAdmin4][Patch] RM #3277 Runtime startup error handling is broken on Windows

Hi Akshay, Thanks for the patch. It looks good to me as long as it also works on windows. Sincerely, Victoria & Anthony On Thu, May 31, 2018 at 4:53 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch file to fix RM #3277 Runtime startup error handling > is broken on Windows. I ha

[pgAdmin4][Patch] RM #3277 Runtime startup error handling is broken on Windows

Hi Hackers, Attached is the patch file to fix RM #3277 Runtime startup error handling is broken on Windows. I have figure out the crash at the following call of Server.cpp(line no 326): PyRun_SimpleFile(fdopen(PyObject_AsFileDescriptor(PyFileObject),"r"), m_ appfile_utf8.data()) When application

Re: [pgAdmin4][Patch]: RM #3277 Runtime startup error handling is broken on Windows.

Hi On Fri, May 11, 2018 at 7:23 AM, Akshay Joshi wrote: > Hi > > On Thu, May 10, 2018 at 7:38 PM, Dave Page wrote: > >> Hi >> >> On Thu, May 10, 2018 at 2:00 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find the attached patch to fix RM #3277 Run

Re: [pgAdmin4][Patch]: RM #3277 Runtime startup error handling is broken on Windows.

Hi On Thu, May 10, 2018 at 7:38 PM, Dave Page wrote: > Hi > > On Thu, May 10, 2018 at 2:00 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch to fix RM #3277 Runtime startup error >> handling is broken on Windows. >> >> This issue is

Re: [pgAdmin4][Patch]: RM #3277 Runtime startup error handling is broken on Windows.

Hi On Thu, May 10, 2018 at 2:00 PM, Akshay Joshi wrote: > Hi Hackers, > > Please find the attached patch to fix RM #3277 Runtime startup error > handling is broken on Windows. > > This issue is regression of RM #3177 "Sporadically crashes on Windows when > exit". Where below code of pgAdmin4.cpp

[pgAdmin4][Patch]: RM #3277 Runtime startup error handling is broken on Windows.

Hi Hackers, Please find the attached patch to fix RM #3277 Runtime startup error handling is broken on Windows. This issue is regression of RM #3177 "Sporadically crashes on Windows when exit". Where below code of pgAdmin4.cpp creates the problem: *QObject::connect(server, SIGNAL(finished()), ser