Re: [pgAdmin4][Patch]: Minor JS Fix

2018-05-15 Thread Joao De Almeida Pereira
Hi, The code looks fine, all tests pass and linter. Once again, not to sound like a broken record, we could have done some much more to improve our code base Why didn't we extract that function into a more testable place? In order for the code to become more clean and modular, we should try t

[pgAdmin4][Patch]: Minor JS Fix

2018-05-14 Thread Khushboo Vashi
Hi, Please find the attached monir patch to fix the JS issue. Thanks, Khushboo diff --git a/web/pgadmin/tools/debugger/static/js/direct.js b/web/pgadmin/tools/debugger/static/js/direct.js index b9cb2ec..0326082 100644 --- a/web/pgadmin/tools/debugger/static/js/direct.js +++ b/web/pgadmin/tools/de