Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

2017-11-21 Thread Dave Page
Thanks! Patch applied, with a minor change to default the query tool header to a white background if a custom foreground colour is specified (otherwise you'd get blue). On Tue, Nov 21, 2017 at 12:07 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patc

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

2017-11-21 Thread Khushboo Vashi
On Tue, Nov 21, 2017 at 5:37 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch with changes suggested by Ashesh. > Hopefully the last revision :) > > +1 :) > > On Tue, Nov 21, 2017 at 4:12 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Da

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

2017-11-21 Thread Dave Page
Hi On Mon, Nov 20, 2017 at 5:47 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > On Mon, Nov 20, 2017 at 10:40 PM, Dave Page wrote: > >> Hi >> >> On Mon, Nov 20, 2017 at 4:19 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> PFA upd

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

2017-11-20 Thread Dave Page
Hi On Mon, Nov 20, 2017 at 4:19 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch. > OK, that's looking better. I just found a couple of smaller issue this time: - Why can't I select a foreground colour unless I select a non-white background? Th

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

2017-11-16 Thread Dave Page
Hi Looks good. A few changes/suggestions: - There seem to be some debugger calls left in the code, e.g. in editors.js - Instead of bgcolor and font_color, lets use bgcolor and fgcolor (foreground). - The docs are (technically) en_US, so we should use color not colour in them. - If the colours hav

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

2017-11-15 Thread Dave Page
On Wed, Nov 15, 2017 at 9:26 AM, Ashesh Vashi wrote: > On Wed, Nov 15, 2017 at 2:28 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> On Wed, Nov 15, 2017 at 1:20 PM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> Hi Murtuza, >>> >>> On Wed, Nov 15, 2017 at 12:58 PM, Murtuza Za

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

2017-11-15 Thread Ashesh Vashi
On Wed, Nov 15, 2017 at 2:28 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > On Wed, Nov 15, 2017 at 1:20 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Murtuza, >> >> On Wed, Nov 15, 2017 at 12:58 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.c

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

2017-11-15 Thread Murtuza Zabuawala
On Wed, Nov 15, 2017 at 1:20 PM, Ashesh Vashi wrote: > Hi Murtuza, > > On Wed, Nov 15, 2017 at 12:58 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA new patch. >> > If I have reviewed correctly, the current patch allows to select the > colour for background color for server, an

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

2017-11-14 Thread Ashesh Vashi
Hi Murtuza, On Wed, Nov 15, 2017 at 12:58 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA new patch. > If I have reviewed correctly, the current patch allows to select the colour for background color for server, and its children. I believe - we should allow to sel

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

2017-11-14 Thread Murtuza Zabuawala
Hi, Please hold on this patch, As discussed with Ashesh I need to make some changes, I'll send new patch. On Wed, Nov 15, 2017 at 10:07 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch which will allow user to choose background colour for the server. > RM#1383 > > -- > Regards, > Murtuza Zabuaw