Re: [pgAdmin4][Patch#2897] Add support for keyboard navigation in Debugger

2018-01-23 Thread Dave Page
Thanks, patch applied! On Tue, Jan 23, 2018 at 6:37 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find updated patch with docs and JS tests. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Com

Re: [pgAdmin4][Patch#2897] Add support for keyboard navigation in Debugger

2018-01-22 Thread Murtuza Zabuawala
Hi Dave, Please find updated patch with docs and JS tests. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jan 22, 2018 at 4:02 PM, Dave Page wrote: > Hi > > This seems to be missing documentation updates. I would also expect t

Re: [pgAdmin4][Patch#2897] Add support for keyboard navigation in Debugger

2018-01-22 Thread Dave Page
Hi This seems to be missing documentation updates. I would also expect to see some Jasmine unit tests for some/all of the new JS functions. On Tue, Jan 16, 2018 at 1:29 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to add keyboard navigation in Debugger m

[pgAdmin4][Patch#2897] Add support for keyboard navigation in Debugger

2018-01-16 Thread Murtuza Zabuawala
Hi, PFA patch to add keyboard navigation in Debugger module via Tab/Shift-Tab key. RM#2897 Also fixed the issue where user was not able to update values in variable's panel while debugging. RM#2981 Currrently we have execution related shortcuts using accesskey, Shortcuts (Execution related)