Re: [pgAdmin4[RM#3935] Grant wizard fails to list down functions

2019-01-30 Thread Akshay Joshi
Thanks patch applied. On Wed, Jan 30, 2019 at 3:10 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > On Mon, Jan 28, 2019 at 4:38 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Murtuza >> >> Here are my review comments: >> >>- Exact error should be

Re: [pgAdmin4[RM#3935] Grant wizard fails to list down functions

2019-01-28 Thread Akshay Joshi
Hi Murtuza Here are my review comments: - Exact error should be logged in the log file and on GUI we should show message like "Unable to fetch object". - Message should be shown in the status bar. - If there is an error to fetch one kind of object, we should show other objects.

Re: [pgAdmin4[RM#3935] Grant wizard fails to list down functions

2019-01-28 Thread Murtuza Zabuawala
Hi, PFA minor patch, To display an error on UI when there is a backend error for the grant wizard request. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jan 28, 2019 at 12:48 PM Akshay Joshi wrote: > Thanks pa

Re: [pgAdmin4[RM#3935] Grant wizard fails to list down functions

2019-01-27 Thread Akshay Joshi
Thanks patch applied. On Mon, Jan 28, 2019 at 12:01 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where EPAS DB instance running with > *no-redwood-compat* mode fails to list down functions objects in grant > wizard due to 'char' -> 'int' t

[pgAdmin4[RM#3935] Grant wizard fails to list down functions

2019-01-27 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where EPAS DB instance running with *no-redwood-compat* mode fails to list down functions objects in grant wizard due to 'char' -> 'int' type cast error. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_