Re: [pgAdmin 4][Patch]: #7314 - psycopg2 to psycopg3 migration

2022-09-14 Thread Akshay Joshi
Thanks, the patch applied. On Wed, Sep 14, 2022 at 12:23 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached updated patch. > > On Tue, Sep 13, 2022 at 1:05 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> Review co

Re: [pgAdmin 4][Patch]: #7314 - psycopg2 to psycopg3 migration

2022-09-13 Thread Khushboo Vashi
Hi Akshay, Please find the attached updated patch. On Tue, Sep 13, 2022 at 1:05 PM Akshay Joshi wrote: > Hi Khushboo > > Review comments are as follows: > >- View/Edit Data does not work. (Cursor could not be found for the >async connection.) > > Fixed. > >- Graph Visualizer is not

Re: [pgAdmin 4][Patch]: #7314 - psycopg2 to psycopg3 migration

2022-09-13 Thread Akshay Joshi
Hi Khushboo Review comments are as follows: - View/Edit Data does not work. (Cursor could not be found for the async connection.) - Graph Visualizer is not working. (raise IndexError("position out of bound") backend error) - Add psycopg3 support in *setup_pip.py* inside the pkg/pip

Re: [pgAdmin 4][Patch]: #7314 - psycopg2 to psycopg3 migration

2022-09-01 Thread Akshay Joshi
Hi Khushboo Following are the review comments: - Remove psycopg2 from requirements.txt - Set PG_DEFAULT_DRIVER to psycopg3 in config.py - Remove all the imports of 'psycopg2' from the entire project. - Query Tool not working with psycopg3 == 3.1 On Tue, Aug 30, 2022 at 8:57 PM Khush