Re: [pgAdmin][SonarQube] Reduce cognitive complexity

Hi, Please find the updated patch. On Tue, Sep 22, 2020 at 2:56 PM Akshay Joshi wrote: > Hi Aditya > > The patch fixes only 1 code smell and introduce 1 new. Please fix those > and resend the patch. > > On Tue, Sep 22, 2020 at 11:04 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wro

Re: [pgAdmin][SonarQube] Reduce cognitive complexity

Hi Aditya The patch fixes only 1 code smell and introduce 1 new. Please fix those and resend the patch. On Tue, Sep 22, 2020 at 11:04 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached path will reduce the cognitive complexity as > below:web/pgadmin/misc/

[pgAdmin][SonarQube] Reduce cognitive complexity

Hi Hackers, Attached path will reduce the cognitive complexity as below:web/pgadmin/misc/file_manager/__init__.py 40 to 15; 43 to 15 Please review. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant

Re: [pgAdmin][SonarQube] Reduce cognitive complexity

Thanks, patch applied. On Tue, Sep 8, 2020 at 6:13 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Attached patch reduces the cognitive complexity as below: > web/pgadmin/tools/sqleditor/utils/is_begin_required.py - 89 to 15 > web/pgadmin/utils/driver/psycopg2/connection.py - 16

[pgAdmin][SonarQube] Reduce cognitive complexity

Attached patch reduces the cognitive complexity as below: web/pgadmin/tools/sqleditor/utils/is_begin_required.py - 89 to 15 web/pgadmin/utils/driver/psycopg2/connection.py - 16 to 15 web/setup.py - 17 to 15 Please review. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbp

Re: [pgAdmin][SonarQube] Reduce cognitive complexity

Thanks, patch applied. On Thu, Sep 3, 2020 at 3:38 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to reduce cognitive complexity as below: > web/pgadmin/misc/file_manager/__init__.py 20 to 15 > web/pgadmin/tools/grant_wizard/__init__.py 55

Re: [pgAdmin][SonarQube] Reduce cognitive complexity

Thanks, patch applied. On Tue, Sep 1, 2020 at 3:34 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch reduces cognitive complexity as below: > > web/.../server_groups/servers/pgagent/__init__.py - 23 to 15 > web/pgadmin/utils/driver/psycopg2/__init__.

[pgAdmin][SonarQube] Reduce cognitive complexity

Hi Hackers, Attached patch reduces cognitive complexity as below: web/.../server_groups/servers/pgagent/__init__.py - 23 to 15 web/pgadmin/utils/driver/psycopg2/__init__.py - 23 to 15, 17 to 15 web/setup.py 77 to 15 Please review. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engin

Re: [pgAdmin][SonarQube] Reduce cognitive complexity

Thanks, patch applied. On Wed, Aug 12, 2020 at 4:03 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix certain errors occurring when saving > preferences. This is the regression of patch committed. > Please review. > > On Tue, Aug 11, 20

Re: [pgAdmin][SonarQube] Reduce cognitive complexity

Hi Hackers, Attached is the patch to fix certain errors occurring when saving preferences. This is the regression of patch committed. Please review. On Tue, Aug 11, 2020 at 3:32 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Tue, Aug 11, 2020 at 11:42 AM Aditya Toshniwal < > aditya.tosh

Re: [pgAdmin][SonarQube] Reduce cognitive complexity

Thanks, patch applied. On Tue, Aug 11, 2020 at 11:42 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch will reduce cognitive complexity for functions as below: > web/.../servers/pgagent/schedules/__init__.py - 17 to 15 > web/.../servers/pgagent/steps

[pgAdmin][SonarQube] Reduce cognitive complexity

Hi Hackers, Attached patch will reduce cognitive complexity for functions as below: web/.../servers/pgagent/schedules/__init__.py - 17 to 15 web/.../servers/pgagent/steps/__init__.py - 21 to 15; 29 to 15 web/pgadmin/setup/user_info.py - 22 to 15 web/pgadmin/utils/preferences.py - 29 to 15; 44 to 1

Re: [pgAdmin][SonarQube] Reduce cognitive complexity

Thanks, patch applied. On Mon, Jul 27, 2020 at 11:00 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Please ignore the previous patch. Attached is the latest. > > On Mon, Jul 27, 2020 at 10:42 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >>

Re: [pgAdmin][SonarQube] Reduce cognitive complexity

Hi Hackers, Please ignore the previous patch. Attached is the latest. On Mon, Jul 27, 2020 at 10:42 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to reduce cognitive complexity for: > 1) web/.../databases/schemas/views/__init__.py from 11

[pgAdmin][SonarQube] Reduce cognitive complexity

Hi Hackers, Attached is the patch to reduce cognitive complexity for: 1) web/.../databases/schemas/views/__init__.py from 110 to the 15 allowed. 2) web/.../servers/databases/casts/__init__.py from 18 to the 15 allowed. 3) web/.../databases/schemas/collations/__init__.py from 16 to the 15 allowed.

Re: [pgAdmin][SonarQube] Reduce cognitive complexity of functions

Thanks, patch applied. On Mon, Jul 20, 2020 at 12:25 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to reduce cognitive complexity of functions: > 1) web/.../exclusion_constraint/__init__.py > create > from 25 to 15 > 2) web/.../exclusion_c

[pgAdmin][SonarQube] Reduce cognitive complexity of functions

Hi Hackers, Attached is the patch to reduce cognitive complexity of functions: 1) web/.../exclusion_constraint/__init__.py > create > from 25 to 15 2) web/.../exclusion_constraint/__init__.py > sql > from 19 to 15 3) web/.../databases/schemas/utils.py > parse_vacuum_data > from 18 to 15 4) web/...